<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On Tuesday 23 July 2019 12:16 PM, Anand
B Pillai wrote:<br>
</div>
<blockquote type="cite"
cite="mid:7efe519b-5b9c-a462-0222-ded2ccc19afb@anvetsu.com">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<p><font face="Bitstream Vera Sans Mono">Hi all,</font></p>
<font face="Bitstream Vera Sans Mono"> I have an open "PR" -
for review purposes and early feedback only - against my own
master branch</font><br>
<font face="Bitstream Vera Sans Mono">of the foolscap fork from
the py3kport branch.<br>
<br>
<a class="moz-txt-link-freetext"
href="https://github.com/anvetsu/foolscap/pull/1"
moz-do-not-send="true">https://github.com/anvetsu/foolscap/pull/1</a><br>
</font></blockquote>
<br>
Okay, so this code is not yet ready to be raised as a PR against the
original repos master because<br>
it passes just one test (test_banana.py). <br>
<br>
I fixed some basic issues which was causing the Travis job to not
run but all tests except <br>
test_banana.py will *fail* on Python2 (and Python3). So there is no
point in raising a PR<br>
against the original repo at the moment. <br>
<br>
The "PR" which I have raised against my own fork's master is so that
- any one interested could<br>
take a look at the changes and comment. And if you are interested,
you can checkout my repo <br>
and run the test_banana.py test (only) on Python2 and Python3 and
verify (or otherwise) that<br>
it passes for you.<br>
<br>
Once I make all tests pass - against Python2 and Python3 - I will
be in a position to raise a PR against<br>
the original repo. It will be a big PR at that stage.<br>
<br>
Another option if of course - if we get commit rights to Warner's
repo, I can raise frequent PRs against<br>
an "integration" branch - as discussed in call - as soon as test (or
multiple tests) are passing - with <br>
the understanding that CI checks may still fail. We keep
incrementally merging against this branch <br>
till all tests pass(along with CI checks) and we finally merge the
"integration" branch to foolscap master.<br>
<br>
Hope this is clear. Let me know if there are any questions.<br>
<br>
Thanks.<br>
<br>
<blockquote type="cite"
cite="mid:7efe519b-5b9c-a462-0222-ded2ccc19afb@anvetsu.com"> I'd
like someone to review the changes. Kindly email me your github id
so I can add you<br>
to the project - and as a reviewer.<br>
<br>
There are many changed files though you can ignore almost all of
them as they are changes made by the 2to3 tool <br>
and focus on the files listed in the PR comment. <br>
<br>
Expectations:<br>
<br>
1. Checkout the branch and try the "test_banana.py" test on
Python3 (Mine is 3.6.7, so try anything same and upwards)<br>
and Python2 (2.7.15) <br>
2. Review the core files mentioned in the port and give feedback
of any.<br>
<br>
I will close this "PR" after I get any feedback.<br>
<br>
<p>Thanks.<br>
</p>
<pre class="moz-signature" cols="72">--
Kind Regards,
--Anand
-----------------------------------
Founder & Director,
Anvetsu Technologies Pvt Ltd (OPC),
<a class="moz-txt-link-freetext" href="https://www.anvetsu.com" moz-do-not-send="true">https://www.anvetsu.com</a>
<a class="moz-txt-link-freetext" href="https://www.anvetsu.training" moz-do-not-send="true">https://www.anvetsu.training</a>
-----------------------------------</pre>
</blockquote>
<p><br>
</p>
<pre class="moz-signature" cols="72">--
Kind Regards,
--Anand
-----------------------------------
Founder & Director,
Anvetsu Technologies Pvt Ltd (OPC),
<a class="moz-txt-link-freetext" href="https://www.anvetsu.com">https://www.anvetsu.com</a>
<a class="moz-txt-link-freetext" href="https://www.anvetsu.training">https://www.anvetsu.training</a>
-----------------------------------</pre>
</body>
</html>