[tahoe-lafs-trac-stream] [Tahoe-LAFS] #2754: remove "_appname.py" file, variable application name

Tahoe-LAFS trac at tahoe-lafs.org
Tue Mar 22 20:56:14 UTC 2016


#2754: remove "_appname.py" file, variable application name
-----------------------+------------------------
 Reporter:  warner     |          Owner:
     Type:  task       |         Status:  new
 Priority:  normal     |      Milestone:  1.12.0
Component:  packaging  |        Version:  1.10.2
 Keywords:             |  Launchpad Bug:
-----------------------+------------------------
 A long long time ago, at !AllMyData, we had different branches of the
 Tahoe source tree for different deployment environments. We had a "prod"
 branch for production, a "dev" branch for development, and I think a
 "client" or "server" or something else.

 To be able to have multiple branches installed on a single box, we added
 code to alter the installed bin/tahoe name. We were using Darcs back then,
 and the easiest thing we could think of was to put the "application name"
 into a file, and add a single darcs patch that changed this file's
 contents to "prod" or "dev" or whatever. On the prod machines, we'd have a
 darcs repo that was exactly like the main repo, except it would have this
 one extra appname-changing patch.

 That era is long gone, and we no longer need that complexity in our
 setup.py. If people really want this feature (maybe someone wants to fork
 tahoe and call it "shmahoe"), they can just edit setup.py to change the
 name of the entrypoint script.

 (actually, it might be slightly harder than that: we have some tests that
 check that the literal string "tahoe" is in the output of `tahoe
 --version`. If we really want to support forking, then keeping this in a
 `allmydata.__appname__` constant would be easier. But I don't think this
 is worth it)

 Actions:

 * delete `src/allmydata/_appname.py`
 * remove the `setup.py` code that reads/writes it
 * maybe change the tests that look for `allmydata.__appname__` in command
 output and have them look for a hard-coded "tahoe" instead. This includes
 test_cli, test_client, test_runner, and test_system.

--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2754>
Tahoe-LAFS <https://Tahoe-LAFS.org>
secure decentralized storage


More information about the tahoe-lafs-trac-stream mailing list