Ticket #1483: fix-1483.darcs.patch

File fix-1483.darcs.patch, 33.1 KB (added by davidsarah, at 2011-08-15T00:06:42Z)

interfaces.py: ensure that NoSuchChildError? can be converted to str even when it is for a non-ASCII name. fixes #1483

Line 
11 patch for repository http://tahoe-lafs.org/source/tahoe-lafs/trunk:
2
3Sun Aug 14 23:59:59 GMT Daylight Time 2011  david-sarah@jacaranda.org
4  * interfaces.py: ensure that NoSuchChildError can be converted to str even when it is for a non-ASCII name. fixes #1483
5
6New patches:
7
8[interfaces.py: ensure that NoSuchChildError can be converted to str even when it is for a non-ASCII name. fixes #1483
9david-sarah@jacaranda.org**20110814225959
10 Ignore-this: d0069952ac7f5a13bdf5e957c7ae78a8
11] hunk ./src/allmydata/interfaces.py 836
12 
13 class NoSuchChildError(Exception):
14     """A directory node was asked to fetch a child which does not exist."""
15+    def __str__(self):
16+        # avoid UnicodeEncodeErrors when converting to str
17+        return self.__repr__()
18 
19 class ChildOfWrongTypeError(Exception):
20     """An operation was attempted on a child of the wrong type (file or directory)."""
21
22Context:
23
24[test_client.py: relax a check in test_create_drop_uploader so that it should pass on Python 2.4.x. refs #1429
25david-sarah@jacaranda.org**20110810052504
26 Ignore-this: 1380749ceaf33c30e26c50d57476616c
27]
28[test/common_util.py: correct fix to mkdir_nonascii. refs #1472
29david-sarah@jacaranda.org**20110810051906
30 Ignore-this: 93c0c33370bc47d95c26c4cce8e05290
31]
32[test/common_util.py: fix a typo. refs #1472
33david-sarah@jacaranda.org**20110810044235
34 Ignore-this: f88643d7c82cb3577686d77bbff9e2bc
35]
36[test_client.py, test_drop_upload.py: fix pyflakes warnings.
37david-sarah@jacaranda.org**20110810034505
38 Ignore-this: 1e2d71bf2f43d63cbb423d32a6f96793
39]
40[Factor out methods dealing with non-ASCII directories and filenames from test_drop_upload.py into common_util.py. refs #1429, #1472
41david-sarah@jacaranda.org**20110810031558
42 Ignore-this: 3de8f945fa7a58fc318a1184bad0fd1a
43]
44[test_client.py: add a test that the drop-uploader is initialized correctly by client.py. Also give the DropUploader service a name, which is necessary for the test. refs #1429
45david-sarah@jacaranda.org**20110810030538
46 Ignore-this: 13d511ea9bbe9da2dcffe4a91ce94eae
47]
48[drop-upload: rename 'start' method to 'startService', which is what you're supposed to use to start a Service. refs #1429
49david-sarah@jacaranda.org**20110810030345
50 Ignore-this: d1f5e5c63937ea37be37324e2f1ae99d
51]
52[test_drop_upload.py: add comment explaining why we don't use FilePath.setContent. refs #1429
53david-sarah@jacaranda.org**20110810025942
54 Ignore-this: b95358030b63cb467d1d7f1b9a9b6978
55]
56[test_drop_upload.py: fix some grammatical and spelling nits. refs #1429
57david-sarah@jacaranda.org**20110809221231
58 Ignore-this: fd331acddd9f754173f274a34fe62f03
59]
60[drop-upload: report the configured local directory being absent differently from it being a file
61zooko@zooko.com**20110809220930
62 Ignore-this: a08879100f5f20e609be3f0ffa3b25cc
63 refs #1429
64]
65[drop-upload: rename the 'upload.uri' parameter to 'upload.dircap', and a couple of cleanups to error messages. refs #1429
66zooko@zooko.com**20110809220508
67 Ignore-this: 4846368cbe331e8653bdce1f314e276b
68 I rerecorded this patch, originally by David-Sarah, to use "darcs replace" instead of editing to do the renames. This uncovered one missed rename in Client.init_drop_uploader. (Which also means that code isn't exercised by the current unit tests.)
69 refs #1429
70]
71[drop-upload test for non-existent local dir separately from test for non-directory local dir
72zooko@zooko.com**20110809220115
73 Ignore-this: cd85f345c02f5cb71b1c1527bd4ebddc
74 A candidate patch for #1429 has a bug when it is using FilePath.is_dir() to detect whether the configured local dir exists and is a directory. FilePath.is_dir() raises exception, instead of returning False, if the thing doesn't exist. This test is to make sure that DropUploader.__init__ raise different exceptions for those two cases.
75 refs #1429
76]
77[drop-upload: unit tests for the configuration options being named "cap" instead of "uri"
78zooko@zooko.com**20110809215913
79 Ignore-this: 958c78fffb3d76b3e4817647f824e7f9
80 This is a subset of a patch that David-Sarah attached to #1429. This is just the unit-tests part of that patch, and uses darcs record instead of hunks to change the names.
81 refs #1429
82]
83[src/allmydata/storage/server.py: use the filesystem of storage/shares/, rather than storage/, to calculate remaining space. fixes #1384
84david-sarah@jacaranda.org**20110719022752
85 Ignore-this: a4781043cfd453dbb66ae4f108d80bea
86]
87[test_storage.py: test that we are using the filesystem of storage/shares/, rather than storage/, to calculate remaining space, and that the HTML status output reflects the values returned by fileutil.get_disk_stats. This version works with older versions of the mock library. refs #1384
88david-sarah@jacaranda.org**20110809190722
89 Ignore-this: db447caca37a459ca49563efa58db58c
90]
91[Work around ref #1472 by having test_drop_upload delete the non-ASCII directories it creates.
92david-sarah@jacaranda.org**20110809012334
93 Ignore-this: 5881fd5db419ba8ad12e0b2a82f6c4f0
94]
95[Remove all trailing whitespace from .py files.
96david-sarah@jacaranda.org**20110809001117
97 Ignore-this: d2658b5ce44af70cc606ae4d3085b7cc
98]
99[test_drop_upload.py: fix unused imports. refs #1429
100david-sarah@jacaranda.org**20110808235422
101 Ignore-this: 834f6b946bfea699d7d8c743edd66671
102]
103[Documentation for drop-upload frontend. refs #1429
104david-sarah@jacaranda.org**20110808182146
105 Ignore-this: b33110834e586c0b784d1736c2af5779
106]
107[Drop-upload frontend, rerecorded for 1.9 beta (and correcting a minor mistake). Includes some fixes for Windows but not the Windows inotify implementation. fixes #1429
108david-sarah@jacaranda.org**20110808234049
109 Ignore-this: 67f824c7f554e9a3a85f9fd2e1123d97
110]
111[node.py: ensure that client and introducer nodes record their port number and use that port on the next restart, fixing a regression caused by #1385. fixes #1469.
112david-sarah@jacaranda.org**20110806221934
113 Ignore-this: 1aa9d340b6570320ab2f9edc89c9e0a8
114]
115[test_runner.py: fix a race condition in the test when NODE_URL_FILE is written before PORTNUM_FILE. refs #1469
116david-sarah@jacaranda.org**20110806231842
117 Ignore-this: ab01ae7cec3a073e29eec473e64052a0
118]
119[test_runner.py: cleanups of HOTLINE_FILE writing and removal.
120david-sarah@jacaranda.org**20110806231652
121 Ignore-this: 25f5c5d6f5d8faebb26a4ce80110a335
122]
123[test_runner.py: remove an unused constant.
124david-sarah@jacaranda.org**20110806221416
125 Ignore-this: eade2695cbabbea9cafeaa8debe410bb
126]
127[node.py: fix the error path for a missing config option so that it works for a Unicode base directory.
128david-sarah@jacaranda.org**20110806221007
129 Ignore-this: 4eb9cc04b2ce05182a274a0d69dafaf3
130]
131[test_runner.py: test that client and introducer nodes record their port number and use that port on the next restart. This tests for a regression caused by ref #1385.
132david-sarah@jacaranda.org**20110806220635
133 Ignore-this: 40a0c040b142dbddd47e69b3c3712f5
134]
135[test_runner.py: fix a bug in CreateNode.do_create introduced in changeset [5114] when the tahoe.cfg file has been written with CRLF line endings. refs #1385
136david-sarah@jacaranda.org**20110804003032
137 Ignore-this: 7b7afdcf99da6671afac2d42828883eb
138]
139[test_client.py: repair Basic.test_error_on_old_config_files. refs #1385
140david-sarah@jacaranda.org**20110803235036
141 Ignore-this: 31e2a9c3febe55948de7e144353663e
142]
143[test_checker.py: increase timeout for TooParallel.test_immutable again. The ARM buildslave took 38 seconds, so 40 seconds is too close to the edge; make it 80.
144david-sarah@jacaranda.org**20110803214042
145 Ignore-this: 2d8026a6b25534e01738f78d6c7495cb
146]
147[test_runner.py: fix RunNode.test_introducer to not rely on the mtime of introducer.furl to detect when the node has restarted. Instead we detect when node.url has been written. refs #1385
148david-sarah@jacaranda.org**20110803180917
149 Ignore-this: 11ddc43b107beca42cb78af88c5c394c
150]
151[Further improve error message about old config files. refs #1385
152david-sarah@jacaranda.org**20110803174546
153 Ignore-this: 9d6cc3c288d9863dce58faafb3855917
154]
155[Slightly improve error message about old config files (avoid unnecessary Unicode escaping). refs #1385
156david-sarah@jacaranda.org**20110803163848
157 Ignore-this: a3e3930fba7ccf90b8db3d2ed5829df4
158]
159[test_checker.py: increase timeout for TooParallel.test_immutable (was consistently failing on ARM buildslave).
160david-sarah@jacaranda.org**20110803163213
161 Ignore-this: d0efceaf12628e8791862b80c85b5d56
162]
163[Fix the bug that prevents an introducer from starting when introducer.furl already exists. Also remove some dead code that used to read old config files, and rename 'warn_about_old_config_files' to reflect that it's not a warning. refs #1385
164david-sarah@jacaranda.org**20110803013212
165 Ignore-this: 2d6cd14bd06a7493b26f2027aff78f4d
166]
167[test_runner.py: modify RunNode.test_introducer to test that starting an introducer works when the introducer.furl file already exists. refs #1385
168david-sarah@jacaranda.org**20110803012704
169 Ignore-this: 8cf7f27ac4bfbb5ad8ca4a974106d437
170]
171[verifier: correct a bug introduced in changeset [5106] that caused us to only verify the first block of a file. refs #1395
172david-sarah@jacaranda.org**20110802172437
173 Ignore-this: 87fb77854a839ff217dce73544775b11
174]
175[test_repairer: add a deterministic test of share data corruption that always flips the bits of the last byte of the share data. refs #1395
176david-sarah@jacaranda.org**20110802175841
177 Ignore-this: 72f54603785007e88220c8d979e08be7
178]
179[verifier: serialize the fetching of blocks within a share so that we don't use too much RAM
180zooko@zooko.com**20110802063703
181 Ignore-this: debd9bac07dcbb6803f835a9e2eabaa1
182 
183 Shares are still verified in parallel, but within a share, don't request a
184 block until the previous block has been verified and the memory we used to hold
185 it has been freed up.
186 
187 Patch originally due to Brian. This version has a mockery-patchery-style test
188 which is "low tech" (it implements the patching inline in the test code instead
189 of using an extension of the mock.patch() function from the mock library) and
190 which unpatches in case of exception.
191 
192 fixes #1395
193]
194[add docs about timing-channel attacks
195Brian Warner <warner@lothar.com>**20110802044541
196 Ignore-this: 73114d5f5ed9ce252597b707dba3a194
197]
198['test-coverage' now needs PYTHONPATH=. to find TOP/twisted/plugins/
199Brian Warner <warner@lothar.com>**20110802041952
200 Ignore-this: d40f1f4cb426ea1c362fc961baedde2
201]
202[remove nodeid from WriteBucketProxy classes and customers
203warner@lothar.com**20110801224317
204 Ignore-this: e55334bb0095de11711eeb3af827e8e8
205 refs #1363
206]
207[remove get_serverid() from ReadBucketProxy and customers, including Checker
208warner@lothar.com**20110801224307
209 Ignore-this: 837aba457bc853e4fd413ab1a94519cb
210 and debug.py dump-share commands
211 refs #1363
212]
213[reject old-style (pre-Tahoe-LAFS-v1.3) configuration files
214zooko@zooko.com**20110801232423
215 Ignore-this: b58218fcc064cc75ad8f05ed0c38902b
216 Check for the existence of any of them and if any are found raise exception which will abort the startup of the node.
217 This is a backwards-incompatible change for anyone who is still using old-style configuration files.
218 fixes #1385
219]
220[whitespace-cleanup
221zooko@zooko.com**20110725015546
222 Ignore-this: 442970d0545183b97adc7bd66657876c
223]
224[tests: use fileutil.write() instead of open() to ensure timely close even without CPython-style reference counting
225zooko@zooko.com**20110331145427
226 Ignore-this: 75aae4ab8e5fa0ad698f998aaa1888ce
227 Some of these already had an explicit close() but I went ahead and replaced them with fileutil.write() as well for the sake of uniformity.
228]
229[Address Kevan's comment in #776 about Options classes missed when adding 'self.command_name'. refs #776, #1359
230david-sarah@jacaranda.org**20110801221317
231 Ignore-this: 8881d42cf7e6a1d15468291b0cb8fab9
232]
233[docs/frontends/webapi.rst: change some more instances of 'delete' or 'remove' to 'unlink', change some section titles, and use two blank lines between all sections. refs #776, #1104
234david-sarah@jacaranda.org**20110801220919
235 Ignore-this: 572327591137bb05c24c44812d4b163f
236]
237[cleanup: implement rm as a synonym for unlink rather than vice-versa. refs #776
238david-sarah@jacaranda.org**20110801220108
239 Ignore-this: 598dcbed870f4f6bb9df62de9111b343
240]
241[docs/webapi.rst: address Kevan's comments about use of 'delete' on ref #1104
242david-sarah@jacaranda.org**20110801205356
243 Ignore-this: 4fbf03864934753c951ddeff64392491
244]
245[docs: some changes of 'delete' or 'rm' to 'unlink'. refs #1104
246david-sarah@jacaranda.org**20110713002722
247 Ignore-this: 304d2a330d5e6e77d5f1feed7814b21c
248]
249[WUI: change the label of the button to unlink a file from 'del' to 'unlink'. Also change some internal names to 'unlink', and allow 't=unlink' as a synonym for 't=delete' in the web-API interface. Incidentally, improve a test to check for the rename button as well as the unlink button. fixes #1104
250david-sarah@jacaranda.org**20110713001218
251 Ignore-this: 3eef6b3f81b94a9c0020a38eb20aa069
252]
253[src/allmydata/web/filenode.py: delete a stale comment that was made incorrect by changeset [3133].
254david-sarah@jacaranda.org**20110801203009
255 Ignore-this: b3912e95a874647027efdc97822dd10e
256]
257[fix typo introduced during rebasing of 'remove get_serverid from
258Brian Warner <warner@lothar.com>**20110801200341
259 Ignore-this: 4235b0f585c0533892193941dbbd89a8
260 DownloadStatus.add_dyhb_request and customers' patch, to fix test failure.
261]
262[remove get_serverid from DownloadStatus.add_dyhb_request and customers
263zooko@zooko.com**20110801185401
264 Ignore-this: db188c18566d2d0ab39a80c9dc8f6be6
265 This patch is a rebase of a patch originally written by Brian. I didn't change any of the intent of Brian's patch, just ported it to current trunk.
266 refs #1363
267]
268[remove get_serverid from DownloadStatus.add_block_request and customers
269zooko@zooko.com**20110801185344
270 Ignore-this: 8bfa8201d6147f69b0fbe31beea9c1e
271 This is a rebase of a patch Brian originally wrote. I haven't changed the intent of that patch, just ported it to trunk.
272 refs #1363
273]
274[apply zooko's advice: storage_client get_known_servers() returns a frozenset, caller sorts
275warner@lothar.com**20110801174452
276 Ignore-this: 2aa13ea6cbed4e9084bd604bf8633692
277 refs #1363
278]
279[test_immutable.Test: rewrite to use NoNetworkGrid, now takes 2.7s not 97s
280warner@lothar.com**20110801174444
281 Ignore-this: 54f30b5d7461d2b3514e2a0172f3a98c
282 remove now-unused ShareManglingMixin
283 refs #1363
284]
285[DownloadStatus.add_known_share wants to be used by Finder, web.status
286warner@lothar.com**20110801174436
287 Ignore-this: 1433bcd73099a579abe449f697f35f9
288 refs #1363
289]
290[replace IServer.name() with get_name(), and get_longname()
291warner@lothar.com**20110801174428
292 Ignore-this: e5a6f7f6687fd7732ddf41cfdd7c491b
293 
294 This patch was originally written by Brian, but was re-recorded by Zooko to use
295 darcs replace instead of hunks for any file in which it would result in fewer
296 total hunks.
297 refs #1363
298]
299[upload.py: apply David-Sarah's advice rename (un)contacted(2) trackers to first_pass/second_pass/next_pass
300zooko@zooko.com**20110801174143
301 Ignore-this: e36e1420bba0620a0107bd90032a5198
302 This patch was written by Brian but was re-recorded by Zooko (with David-Sarah looking on) to use darcs replace instead of editing to rename the three variables to their new names.
303 refs #1363
304]
305[Coalesce multiple Share.loop() calls, make downloads faster. Closes #1268.
306Brian Warner <warner@lothar.com>**20110801151834
307 Ignore-this: 48530fce36c01c0ff708f61c2de7e67a
308]
309[src/allmydata/_auto_deps.py: 'i686' is another way of spelling x86.
310david-sarah@jacaranda.org**20110801034035
311 Ignore-this: 6971e0621db2fba794d86395b4d51038
312]
313[tahoe_rm.py: better error message when there is no path. refs #1292
314david-sarah@jacaranda.org**20110122064212
315 Ignore-this: ff3bb2c9f376250e5fd77eb009e09018
316]
317[test_cli.py: Test for error message when 'tahoe rm' is invoked without a path. refs #1292
318david-sarah@jacaranda.org**20110104105108
319 Ignore-this: 29ec2f2e0251e446db96db002ad5dd7d
320]
321[src/allmydata/__init__.py: suppress a spurious warning from 'bin/tahoe --version[-and-path]' about twisted-web and twisted-core packages.
322david-sarah@jacaranda.org**20110801005209
323 Ignore-this: 50e7cd53cca57b1870d9df0361c7c709
324]
325[test_cli.py: use to_str on fields loaded using simplejson.loads in new tests. refs #1304
326david-sarah@jacaranda.org**20110730032521
327 Ignore-this: d1d6dfaefd1b4e733181bf127c79c00b
328]
329[cli: make 'tahoe cp' overwrite mutable files in-place
330Kevan Carstensen <kevan@isnotajoke.com>**20110729202039
331 Ignore-this: b2ad21a19439722f05c49bfd35b01855
332]
333[SFTP: write an error message to standard error for unrecognized shell commands. Change the existing message for shell sessions to be written to standard error, and refactor some duplicated code. Also change the lines of the error messages to end in CRLF, and take into account Kevan's review comments. fixes #1442, #1446
334david-sarah@jacaranda.org**20110729233102
335 Ignore-this: d2f2bb4664f25007d1602bf7333e2cdd
336]
337[src/allmydata/scripts/cli.py: fix pyflakes warning.
338david-sarah@jacaranda.org**20110728021402
339 Ignore-this: 94050140ddb99865295973f49927c509
340]
341[Fix the help synopses of CLI commands to include [options] in the right place. fixes #1359, fixes #636
342david-sarah@jacaranda.org**20110724225440
343 Ignore-this: 2a8e488a5f63dabfa9db9efd83768a5
344]
345[encodingutil: argv and output encodings are always the same on all platforms. Lose the unnecessary generality of them being different. fixes #1120
346david-sarah@jacaranda.org**20110629185356
347 Ignore-this: 5ebacbe6903dfa83ffd3ff8436a97787
348]
349[docs/man/tahoe.1: add man page. fixes #1420
350david-sarah@jacaranda.org**20110724171728
351 Ignore-this: fc7601ec7f25494288d6141d0ae0004c
352]
353[Update the dependency on zope.interface to fix an incompatiblity between Nevow and zope.interface 3.6.4. fixes #1435
354david-sarah@jacaranda.org**20110721234941
355 Ignore-this: 2ff3fcfc030fca1a4d4c7f1fed0f2aa9
356]
357[frontends/ftpd.py: remove the check for IWriteFile.close since we're now guaranteed to be using Twisted >= 10.1 which has it.
358david-sarah@jacaranda.org**20110722000320
359 Ignore-this: 55cd558b791526113db3f83c00ec328a
360]
361[Update the dependency on Twisted to >= 10.1. This allows us to simplify some documentation: it's no longer necessary to install pywin32 on Windows, or apply a patch to Twisted in order to use the FTP frontend. fixes #1274, #1438. refs #1429
362david-sarah@jacaranda.org**20110721233658
363 Ignore-this: 81b41745477163c9b39c0b59db91cc62
364]
365[misc/build_helpers/run_trial.py: undo change to block pywin32 (it didn't work because run_trial.py is no longer used). refs #1334
366david-sarah@jacaranda.org**20110722035402
367 Ignore-this: 5d03f544c4154f088e26c7107494bf39
368]
369[misc/build_helpers/run_trial.py: ensure that pywin32 is not on the sys.path when running the test suite. Includes some temporary debugging printouts that will be removed. refs #1334
370david-sarah@jacaranda.org**20110722024907
371 Ignore-this: 5141a9f83a4085ed4ca21f0bbb20bb9c
372]
373[docs/running.rst: use 'tahoe run ~/.tahoe' instead of 'tahoe run' (the default is the current directory, unlike 'tahoe start').
374david-sarah@jacaranda.org**20110718005949
375 Ignore-this: 81837fbce073e93d88a3e7ae3122458c
376]
377[docs/running.rst: say to put the introducer.furl in tahoe.cfg.
378david-sarah@jacaranda.org**20110717194315
379 Ignore-this: 954cc4c08e413e8c62685d58ff3e11f3
380]
381[README.txt: say that quickstart.rst is in the docs directory.
382david-sarah@jacaranda.org**20110717192400
383 Ignore-this: bc6d35a85c496b77dbef7570677ea42a
384]
385[setup: remove the dependency on foolscap's "secure_connections" extra, add a dependency on pyOpenSSL
386zooko@zooko.com**20110717114226
387 Ignore-this: df222120d41447ce4102616921626c82
388 fixes #1383
389]
390[test_sftp.py cleanup: remove a redundant definition of failUnlessReallyEqual.
391david-sarah@jacaranda.org**20110716181813
392 Ignore-this: 50113380b368c573f07ac6fe2eb1e97f
393]
394[docs: add missing link in NEWS.rst
395zooko@zooko.com**20110712153307
396 Ignore-this: be7b7eb81c03700b739daa1027d72b35
397]
398[contrib: remove the contributed fuse modules and the entire contrib/ directory, which is now empty
399zooko@zooko.com**20110712153229
400 Ignore-this: 723c4f9e2211027c79d711715d972c5
401 Also remove a couple of vestigial references to figleaf, which is long gone.
402 fixes #1409 (remove contrib/fuse)
403]
404[add Protovis.js-based download-status timeline visualization
405Brian Warner <warner@lothar.com>**20110629222606
406 Ignore-this: 477ccef5c51b30e246f5b6e04ab4a127
407 
408 provide status overlap info on the webapi t=json output, add decode/decrypt
409 rate tooltips, add zoomin/zoomout buttons
410]
411[add more download-status data, fix tests
412Brian Warner <warner@lothar.com>**20110629222555
413 Ignore-this: e9e0b7e0163f1e95858aa646b9b17b8c
414]
415[prepare for viz: improve DownloadStatus events
416Brian Warner <warner@lothar.com>**20110629222542
417 Ignore-this: 16d0bde6b734bb501aa6f1174b2b57be
418 
419 consolidate IDownloadStatusHandlingConsumer stuff into DownloadNode
420]
421[docs: fix error in crypto specification that was noticed by Taylor R Campbell <campbell+tahoe@mumble.net>
422zooko@zooko.com**20110629185711
423 Ignore-this: b921ed60c1c8ba3c390737fbcbe47a67
424]
425[setup.py: don't make bin/tahoe.pyscript executable. fixes #1347
426david-sarah@jacaranda.org**20110130235809
427 Ignore-this: 3454c8b5d9c2c77ace03de3ef2d9398a
428]
429[Makefile: remove targets relating to 'setup.py check_auto_deps' which no longer exists. fixes #1345
430david-sarah@jacaranda.org**20110626054124
431 Ignore-this: abb864427a1b91bd10d5132b4589fd90
432]
433[Makefile: add 'make check' as an alias for 'make test'. Also remove an unnecessary dependency of 'test' on 'build' and 'src/allmydata/_version.py'. fixes #1344
434david-sarah@jacaranda.org**20110623205528
435 Ignore-this: c63e23146c39195de52fb17c7c49b2da
436]
437[Rename test_package_initialization.py to (much shorter) test_import.py .
438Brian Warner <warner@lothar.com>**20110611190234
439 Ignore-this: 3eb3dbac73600eeff5cfa6b65d65822
440 
441 The former name was making my 'ls' listings hard to read, by forcing them
442 down to just two columns.
443]
444[tests: fix tests to accomodate [20110611153758-92b7f-0ba5e4726fb6318dac28fb762a6512a003f4c430]
445zooko@zooko.com**20110611163741
446 Ignore-this: 64073a5f39e7937e8e5e1314c1a302d1
447 Apparently none of the two authors (stercor, terrell), three reviewers (warner, davidsarah, terrell), or one committer (me) actually ran the tests. This is presumably due to #20.
448 fixes #1412
449]
450[wui: right-align the size column in the WUI
451zooko@zooko.com**20110611153758
452 Ignore-this: 492bdaf4373c96f59f90581c7daf7cd7
453 Thanks to Ted "stercor" Rolle Jr. and Terrell Russell.
454 fixes #1412
455]
456[docs: three minor fixes
457zooko@zooko.com**20110610121656
458 Ignore-this: fec96579eb95aceb2ad5fc01a814c8a2
459 CREDITS for arc for stats tweak
460 fix link to .zip file in quickstart.rst (thanks to ChosenOne for noticing)
461 English usage tweak
462]
463[docs/running.rst: fix stray HTML (not .rst) link noticed by ChosenOne.
464david-sarah@jacaranda.org**20110609223719
465 Ignore-this: fc50ac9c94792dcac6f1067df8ac0d4a
466]
467[server.py:  get_latencies now reports percentiles _only_ if there are sufficient observations for the interpretation of the percentile to be unambiguous.
468wilcoxjg@gmail.com**20110527120135
469 Ignore-this: 2e7029764bffc60e26f471d7c2b6611e
470 interfaces.py:  modified the return type of RIStatsProvider.get_stats to allow for None as a return value
471 NEWS.rst, stats.py: documentation of change to get_latencies
472 stats.rst: now documents percentile modification in get_latencies
473 test_storage.py:  test_latencies now expects None in output categories that contain too few samples for the associated percentile to be unambiguously reported.
474 fixes #1392
475]
476[docs: revert link in relnotes.txt from NEWS.rst to NEWS, since the former did not exist at revision 5000.
477david-sarah@jacaranda.org**20110517011214
478 Ignore-this: 6a5be6e70241e3ec0575641f64343df7
479]
480[docs: convert NEWS to NEWS.rst and change all references to it.
481david-sarah@jacaranda.org**20110517010255
482 Ignore-this: a820b93ea10577c77e9c8206dbfe770d
483]
484[docs: remove out-of-date docs/testgrid/introducer.furl and containing directory. fixes #1404
485david-sarah@jacaranda.org**20110512140559
486 Ignore-this: 784548fc5367fac5450df1c46890876d
487]
488[scripts/common.py: don't assume that the default alias is always 'tahoe' (it is, but the API of get_alias doesn't say so). refs #1342
489david-sarah@jacaranda.org**20110130164923
490 Ignore-this: a271e77ce81d84bb4c43645b891d92eb
491]
492[setup: don't catch all Exception from check_requirement(), but only PackagingError and ImportError
493zooko@zooko.com**20110128142006
494 Ignore-this: 57d4bc9298b711e4bc9dc832c75295de
495 I noticed this because I had accidentally inserted a bug which caused AssertionError to be raised from check_requirement().
496]
497[M-x whitespace-cleanup
498zooko@zooko.com**20110510193653
499 Ignore-this: dea02f831298c0f65ad096960e7df5c7
500]
501[docs: fix typo in running.rst, thanks to arch_o_median
502zooko@zooko.com**20110510193633
503 Ignore-this: ca06de166a46abbc61140513918e79e8
504]
505[relnotes.txt: don't claim to work on Cygwin (which has been untested for some time). refs #1342
506david-sarah@jacaranda.org**20110204204902
507 Ignore-this: 85ef118a48453d93fa4cddc32d65b25b
508]
509[relnotes.txt: forseeable -> foreseeable. refs #1342
510david-sarah@jacaranda.org**20110204204116
511 Ignore-this: 746debc4d82f4031ebf75ab4031b3a9
512]
513[replace remaining .html docs with .rst docs
514zooko@zooko.com**20110510191650
515 Ignore-this: d557d960a986d4ac8216d1677d236399
516 Remove install.html (long since deprecated).
517 Also replace some obsolete references to install.html with references to quickstart.rst.
518 Fix some broken internal references within docs/historical/historical_known_issues.txt.
519 Thanks to Ravi Pinjala and Patrick McDonald.
520 refs #1227
521]
522[docs: FTP-and-SFTP.rst: fix a minor error and update the information about which version of Twisted fixes #1297
523zooko@zooko.com**20110428055232
524 Ignore-this: b63cfb4ebdbe32fb3b5f885255db4d39
525]
526[munin tahoe_files plugin: fix incorrect file count
527francois@ctrlaltdel.ch**20110428055312
528 Ignore-this: 334ba49a0bbd93b4a7b06a25697aba34
529 fixes #1391
530]
531[corrected "k must never be smaller than N" to "k must never be greater than N"
532secorp@allmydata.org**20110425010308
533 Ignore-this: 233129505d6c70860087f22541805eac
534]
535[Fix a test failure in test_package_initialization on Python 2.4.x due to exceptions being stringified differently than in later versions of Python. refs #1389
536david-sarah@jacaranda.org**20110411190738
537 Ignore-this: 7847d26bc117c328c679f08a7baee519
538]
539[tests: add test for including the ImportError message and traceback entry in the summary of errors from importing dependencies. refs #1389
540david-sarah@jacaranda.org**20110410155844
541 Ignore-this: fbecdbeb0d06a0f875fe8d4030aabafa
542]
543[allmydata/__init__.py: preserve the message and last traceback entry (file, line number, function, and source line) of ImportErrors in the package versions string. fixes #1389
544david-sarah@jacaranda.org**20110410155705
545 Ignore-this: 2f87b8b327906cf8bfca9440a0904900
546]
547[remove unused variable detected by pyflakes
548zooko@zooko.com**20110407172231
549 Ignore-this: 7344652d5e0720af822070d91f03daf9
550]
551[allmydata/__init__.py: Nicer reporting of unparseable version numbers in dependencies. fixes #1388
552david-sarah@jacaranda.org**20110401202750
553 Ignore-this: 9c6bd599259d2405e1caadbb3e0d8c7f
554]
555[update FTP-and-SFTP.rst: the necessary patch is included in Twisted-10.1
556Brian Warner <warner@lothar.com>**20110325232511
557 Ignore-this: d5307faa6900f143193bfbe14e0f01a
558]
559[control.py: remove all uses of s.get_serverid()
560warner@lothar.com**20110227011203
561 Ignore-this: f80a787953bd7fa3d40e828bde00e855
562]
563[web: remove some uses of s.get_serverid(), not all
564warner@lothar.com**20110227011159
565 Ignore-this: a9347d9cf6436537a47edc6efde9f8be
566]
567[immutable/downloader/fetcher.py: remove all get_serverid() calls
568warner@lothar.com**20110227011156
569 Ignore-this: fb5ef018ade1749348b546ec24f7f09a
570]
571[immutable/downloader/fetcher.py: fix diversity bug in server-response handling
572warner@lothar.com**20110227011153
573 Ignore-this: bcd62232c9159371ae8a16ff63d22c1b
574 
575 When blocks terminate (either COMPLETE or CORRUPT/DEAD/BADSEGNUM), the
576 _shares_from_server dict was being popped incorrectly (using shnum as the
577 index instead of serverid). I'm still thinking through the consequences of
578 this bug. It was probably benign and really hard to detect. I think it would
579 cause us to incorrectly believe that we're pulling too many shares from a
580 server, and thus prefer a different server rather than asking for a second
581 share from the first server. The diversity code is intended to spread out the
582 number of shares simultaneously being requested from each server, but with
583 this bug, it might be spreading out the total number of shares requested at
584 all, not just simultaneously. (note that SegmentFetcher is scoped to a single
585 segment, so the effect doesn't last very long).
586]
587[immutable/downloader/share.py: reduce get_serverid(), one left, update ext deps
588warner@lothar.com**20110227011150
589 Ignore-this: d8d56dd8e7b280792b40105e13664554
590 
591 test_download.py: create+check MyShare instances better, make sure they share
592 Server objects, now that finder.py cares
593]
594[immutable/downloader/finder.py: reduce use of get_serverid(), one left
595warner@lothar.com**20110227011146
596 Ignore-this: 5785be173b491ae8a78faf5142892020
597]
598[immutable/offloaded.py: reduce use of get_serverid() a bit more
599warner@lothar.com**20110227011142
600 Ignore-this: b48acc1b2ae1b311da7f3ba4ffba38f
601]
602[immutable/upload.py: reduce use of get_serverid()
603warner@lothar.com**20110227011138
604 Ignore-this: ffdd7ff32bca890782119a6e9f1495f6
605]
606[immutable/checker.py: remove some uses of s.get_serverid(), not all
607warner@lothar.com**20110227011134
608 Ignore-this: e480a37efa9e94e8016d826c492f626e
609]
610[add remaining get_* methods to storage_client.Server, NoNetworkServer, and
611warner@lothar.com**20110227011132
612 Ignore-this: 6078279ddf42b179996a4b53bee8c421
613 MockIServer stubs
614]
615[upload.py: rearrange _make_trackers a bit, no behavior changes
616warner@lothar.com**20110227011128
617 Ignore-this: 296d4819e2af452b107177aef6ebb40f
618]
619[happinessutil.py: finally rename merge_peers to merge_servers
620warner@lothar.com**20110227011124
621 Ignore-this: c8cd381fea1dd888899cb71e4f86de6e
622]
623[test_upload.py: factor out FakeServerTracker
624warner@lothar.com**20110227011120
625 Ignore-this: 6c182cba90e908221099472cc159325b
626]
627[test_upload.py: server-vs-tracker cleanup
628warner@lothar.com**20110227011115
629 Ignore-this: 2915133be1a3ba456e8603885437e03
630]
631[happinessutil.py: server-vs-tracker cleanup
632warner@lothar.com**20110227011111
633 Ignore-this: b856c84033562d7d718cae7cb01085a9
634]
635[upload.py: more tracker-vs-server cleanup
636warner@lothar.com**20110227011107
637 Ignore-this: bb75ed2afef55e47c085b35def2de315
638]
639[upload.py: fix var names to avoid confusion between 'trackers' and 'servers'
640warner@lothar.com**20110227011103
641 Ignore-this: 5d5e3415b7d2732d92f42413c25d205d
642]
643[refactor: s/peer/server/ in immutable/upload, happinessutil.py, test_upload
644warner@lothar.com**20110227011100
645 Ignore-this: 7ea858755cbe5896ac212a925840fe68
646 
647 No behavioral changes, just updating variable/method names and log messages.
648 The effects outside these three files should be minimal: some exception
649 messages changed (to say "server" instead of "peer"), and some internal class
650 names were changed. A few things still use "peer" to minimize external
651 changes, like UploadResults.timings["peer_selection"] and
652 happinessutil.merge_peers, which can be changed later.
653]
654[storage_client.py: clean up test_add_server/test_add_descriptor, remove .test_servers
655warner@lothar.com**20110227011056
656 Ignore-this: efad933e78179d3d5fdcd6d1ef2b19cc
657]
658[test_client.py, upload.py:: remove KiB/MiB/etc constants, and other dead code
659warner@lothar.com**20110227011051
660 Ignore-this: dc83c5794c2afc4f81e592f689c0dc2d
661]
662[test: increase timeout on a network test because Francois's ARM machine hit that timeout
663zooko@zooko.com**20110317165909
664 Ignore-this: 380c345cdcbd196268ca5b65664ac85b
665 I'm skeptical that the test was proceeding correctly but ran out of time. It seems more likely that it had gotten hung. But if we raise the timeout to an even more extravagant number then we can be even more certain that the test was never going to finish.
666]
667[docs/configuration.rst: add a "Frontend Configuration" section
668Brian Warner <warner@lothar.com>**20110222014323
669 Ignore-this: 657018aa501fe4f0efef9851628444ca
670 
671 this points to docs/frontends/*.rst, which were previously underlinked
672]
673[web/filenode.py: avoid calling req.finish() on closed HTTP connections. Closes #1366
674"Brian Warner <warner@lothar.com>"**20110221061544
675 Ignore-this: 799d4de19933f2309b3c0c19a63bb888
676]
677[Add unit tests for cross_check_pkg_resources_versus_import, and a regression test for ref #1355. This requires a little refactoring to make it testable.
678david-sarah@jacaranda.org**20110221015817
679 Ignore-this: 51d181698f8c20d3aca58b057e9c475a
680]
681[allmydata/__init__.py: .name was used in place of the correct .__name__ when printing an exception. Also, robustify string formatting by using %r instead of %s in some places. fixes #1355.
682david-sarah@jacaranda.org**20110221020125
683 Ignore-this: b0744ed58f161bf188e037bad077fc48
684]
685[Refactor StorageFarmBroker handling of servers
686Brian Warner <warner@lothar.com>**20110221015804
687 Ignore-this: 842144ed92f5717699b8f580eab32a51
688 
689 Pass around IServer instance instead of (peerid, rref) tuple. Replace
690 "descriptor" with "server". Other replacements:
691 
692  get_all_servers -> get_connected_servers/get_known_servers
693  get_servers_for_index -> get_servers_for_psi (now returns IServers)
694 
695 This change still needs to be pushed further down: lots of code is now
696 getting the IServer and then distributing (peerid, rref) internally.
697 Instead, it ought to distribute the IServer internally and delay
698 extracting a serverid or rref until the last moment.
699 
700 no_network.py was updated to retain parallelism.
701]
702[TAG allmydata-tahoe-1.8.2
703warner@lothar.com**20110131020101]
704Patch bundle hash:
705c86fab76e205fb936fff9b9fa75b0695f69e9011