[tahoe-dev] [tahoe-lafs] #705: "tahoe mv" unlinks the target even when it is a directory

[tahoe-lafs]

#705: "tahoe mv" unlinks the target even when it is a directory
-------------------------------+--------------------------------------------
 Reporter:  zooko              |           Owner:  kevan
     Type:  defect             |          Status:  new  
 Priority:  critical           |       Milestone:  1.5.0
Component:  code-frontend-cli  |         Version:  1.4.1
 Keywords:  reliability        |   Launchpad_bug:       
-------------------------------+--------------------------------------------

Comment(by kevan):

 Good idea with implementing the behavior in Adder.

 I've written some tests for Adder, and then implemented your first
 suggestion. If you set {{{overwrite}}} to "only_files", then it will
 refuse to overwrite directories. Instead of changing from {{{True}}} to
 "yes" and {{{False}}} to "no", I left those as they are now, since it
 seemed to stand less of a chance of breaking a bunch of stuff. Let me know
 if you want me to change this.

 Do we want to add tests for the new {{{overwrite}}} option to the tests
 for methods that use Adder (e.g.: {{{set_node}}}), or is what I have now
 good enough?

 I'll start working on the webapi stuff next, then alter {{{tahoe_mv.py}}}
 to use the new options.

-- 
Ticket URL: <http://allmydata.org/trac/tahoe/ticket/705#comment:21>
tahoe-lafs <http://allmydata.org>
secure decentralized file storage grid