[tahoe-dev] [tahoe-lafs] #778: "shares of happiness" is the wrong measure; "servers of happiness" is better

[tahoe-lafs]

#778: "shares of happiness" is the wrong measure; "servers of happiness" is
better
--------------------------------+-------------------------------------------
 Reporter:  zooko               |           Owner:  kevan    
     Type:  defect              |          Status:  assigned 
 Priority:  critical            |       Milestone:  undecided
Component:  code-peerselection  |         Version:  1.4.1    
 Keywords:  reliability         |   Launchpad_bug:           
--------------------------------+-------------------------------------------

Comment(by kevan):

 I'm pretty much done, aside from two issues.
   1. The CiphertextDownloader class in
 [source:/src/allmydata/immutable/download.py#L869 download.py] is
 responsible for setting the encoding parameters in the object that it
 saves data to -- this includes the value for happy, which (from what I can
 tell) isn't stored with the file on the grid. Right now, this is set to
 the number of shares retrieved from the grid -- this works fine for the
 current happy behavior, but breaks with the new happy behavior. The
 seemingly obvious way to fix this would be to re-read the configuration
 file and use that, but that seems to make CiphertextDownloader a murkier
 abstraction than necessary. Any ideas for a better way to do this?
   1. I'm running into some writers block with the documentation. Maybe I
 should just post what I have.

 Other than that, everything seems fine -- the new behavior is there and
 working, there are tests for it, and all of the unit tests that relied on
 the old behavior have been fixed to pass with the new behavior.

-- 
Ticket URL: <http://allmydata.org/trac/tahoe/ticket/778#comment:40>
tahoe-lafs <http://allmydata.org>
secure decentralized file storage grid