[tahoe-dev] [tahoe-lafs] #1258: having Tahoe or any dependency installed in site-packages (or any other shared directory) can cause us to run or test the wrong code

[tahoe-lafs]

#1258: having Tahoe or any dependency installed in site-packages (or any other
shared directory) can cause us to run or test the wrong code
------------------------------------+---------------------------------------
     Reporter:  davidsarah          |       Owner:  davidsarah          
         Type:  defect              |      Status:  new                 
     Priority:  major               |   Milestone:  1.8.1               
    Component:  dev-infrastructure  |     Version:  1.8.0               
   Resolution:                      |    Keywords:  setuptools test docs
Launchpad Bug:                      |  
------------------------------------+---------------------------------------

Comment (by davidsarah):

 I just saw what is probably another instance of this (on a tree with local
 changes):
 {{{
 $ python setup.py trial --rterror -s
 allmydata.test.test_system.SystemTest.test_filesystem
 running darcsver
 setup.py darcsver: wrote '1.8.1-r4900' into src/allmydata/_version.py
 running trial
 running egg_info
 writing requirements to src\allmydata_tahoe.egg-info\requires.txt
 writing src\allmydata_tahoe.egg-info\PKG-INFO
 writing top-level names to src\allmydata_tahoe.egg-info\top_level.txt
 writing dependency_links to src\allmydata_tahoe.egg-
 info\dependency_links.txt
 writing entry points to src\allmydata_tahoe.egg-info\entry_points.txt
 writing manifest file 'src\allmydata_tahoe.egg-info\SOURCES.txt'
 running build_ext
 allmydata.test.test_system
   SystemTest
     test_filesystem ... Traceback (most recent call last):
   File "d:\tahoe\tahoe-clean\src\allmydata\test\test_system.py", line
 1609, in _check_mv_with_http_proxy
     self.failUnlessEqual(rc_or_sig, 0, str(res))
 twisted.trial.unittest.FailTest: ('', 'Traceback (most recent call
 last):\r\n  File "d:\\tahoe\\tahoe-clean\\support\\Sc
 ripts\\tahoe.pyscript", line 16, in <module>\r\n    load_entry_point
 (\'allmydata-tahoe==1.8.1-r4900\', \'console_scripts
 \', \'tahoe\')()\r\n  File "c:\\python26\\lib\\site-
 packages\\allmydata\\scripts\\runner.py", line 118, in run\r\n    rc
  = runner(sys.argv[1:], install_node_control=install_node_control)\r\n
 File "c:\\python26\\lib\\site-packages\\allmydat
 a\\scripts\\runner.py", line 104, in runner\r\n    rc =
 cli.dispatch[command](so)\r\n  File "c:\\python26\\lib\\site-pac
 kages\\allmydata\\scripts\\cli.py", line 503, in mv\r\n    rc =
 tahoe_mv.mv(options, mode="move")\r\n  File "c:\\python2
 6\\lib\\site-packages\\allmydata\\scripts\\tahoe_mv.py", line 31, in
 mv\r\n    data = urllib.urlopen(from_url + "?t=json
 ").read()\r\n  File "c:\\Python26\\lib\\urllib.py", line 87, in
 urlopen\r\n    return opener.open(url)\r\n  File "c:\\Py
 thon26\\lib\\urllib.py", line 203, in open\r\n    return getattr(self,
 name)(url)\r\n  File "c:\\Python26\\lib\\urllib.p
 y", line 342, in open_http\r\n    h.endheaders()\r\n  File
 "c:\\Python26\\lib\\httplib.py", line 868, in endheaders\r\n
    self._send_output()\r\n  File "c:\\Python26\\lib\\httplib.py", line
 740, in _send_output\r\n    self.send(msg)\r\n  F
 ile "c:\\Python26\\lib\\httplib.py", line 699, in send\r\n
 self.connect()\r\n  File "c:\\Python26\\lib\\httplib.py",
 line 683, in connect\r\n    self.timeout)\r\n  File
 "c:\\Python26\\lib\\socket.py", line 512, in create_connection\r\n
   raise error, msg\r\nIOError: [Errno socket error] [Errno 10060] A
 connection attempt failed because the connected part
 y did not properly respond after a period of time, or established
 connection failed because connected host has failed to
  respond\r\n', 1)
 not equal:
 a = 1
 b = 0

 [FAIL]
 }}}

 Notice the {{{c:\\python26\\lib\\site-packages\\allmydata}}} paths in the
 traceback. (I don't know how that directory got there; I thought that I'd
 deleted it and not installed Tahoe since.)

 More significantly, when running the whole test suite, this was the only
 test that failed. I thought that when running tests, this bug was
 restricted to testing the wrong code and complaining about it, but
 apparently it can still fail silently, despite
 [source:src/allmydata/test/test_runner.py at 4853#L52 test_the_right_code]
 that we added for #1137 :-(

 I will investigate tomorrow why {{{test_the_right_code}}} didn't detect
 this.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1258#comment:6>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage