[tahoe-dev] [tahoe-lafs] #778: "shares of happiness" is the wrong measure; "servers of happiness" is better

[tahoe-lafs]

#778: "shares of happiness" is the wrong measure; "servers of happiness" is
better
---------------------------------------+------------------------------------
 Reporter:  zooko                      |           Owner:  warner
     Type:  defect                     |          Status:  new   
 Priority:  critical                   |       Milestone:  1.6.0 
Component:  code-peerselection         |         Version:  1.4.1 
 Keywords:  reliability review-needed  |   Launchpad_bug:        
---------------------------------------+------------------------------------

Comment(by davidsarah):

 {{{
  class NotEnoughSharesError(Exception):
      """Download was unable to get enough shares, or upload was unable to
 -    place 'shares_of_happiness' shares."""
 +    place 'servers_of_happiness' shares."""
 }}}

 The description needs to be something like "or upload was unable to meet
 the 'servers_of_happiness' threshold." The name of the name of the
 exception is also not quite right, but I don't have a good suggestion if
 it still needs to be the same exception for upload and download. Perhaps
 it doesn't, in which case how about just "FailedDownloadError" and
 "FailedUploadError"? Why it failed is probably not something that client
 code is likely to switch based on.

-- 
Ticket URL: <http://allmydata.org/trac/tahoe/ticket/778#comment:150>
tahoe-lafs <http://allmydata.org>
secure decentralized file storage grid