[tahoe-dev] [tahoe-lafs] #680: Fix for mutable files with FTP

[tahoe-lafs]

#680: Fix for mutable files with FTP
-------------------------------+--------------------------------------------
     Reporter:  frozenfire     |       Owner:  warner                                                       
         Type:  defect         |      Status:  assigned                                                     
     Priority:  major          |   Milestone:  1.7.1                                                        
    Component:  code-frontend  |     Version:  1.3.0                                                        
   Resolution:                 |    Keywords:  ftpd sftp mutable reliability integrity test known-issue docs
Launchpad Bug:                 |  
-------------------------------+--------------------------------------------
Changes (by davidsarah):

  * milestone:  1.7.0 => 1.7.1


Old description:

> FTP hangs when a directory list contains immutable files, as their
> filesize is the string "?", and Twisted's ftpd expects an integer.
> This patch by warner should fix it.

New description:

 FTP hangs when a directory list contains mutable files, as their filesize
 is the string "?", and Twisted's ftpd expects an integer.
 This patch by warner should fix it.

--

Comment:

 Replying to [comment:13 zooko]:
 > Do we need to document this problem with mutable files in FTP? I don't
 think it is serious enough to deserve an entry in
 [source:docs/known_issues.txt], but maybe in [source:docs/frontends/FTP-
 and-SFTP.txt]? Oh, I see there is already a note in there:
 > {{{
 > Mutable files are not supported by the FTP frontend.
 > }}}
 > (from [source:docs/frontends/FTP-and-SFTP.txt at 4439#L201])
 > Hm, this documentation seems incomplete. What happens if I put a mutable
 file into a directory with {{{tahoe put}}} or {{{tahoe ln}}} or the wui,
 and then I list that directory using my FTP client?

 Well, according to the bug description it hangs (it's not clear whether
 the client hangs or the FTP server, probably the former).

 The patch has not been applied because of the problem in comment:3. On the
 other hand, hanging on a directory listing is a more serious problem than
 failing to download the file correctly in some (broken) clients, so
 perhaps the patch should be applied anyway. Not for 1.7.0, though.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/680#comment:14>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized file storage grid