[tahoe-lafs-trac-stream] [tahoe-lafs] #1389: tahoe import machinery hides details of import errors

[tahoe-lafs]

#1389: tahoe import machinery hides details of import errors
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:  somebody
         Type:  defect   |     Status:  new
     Priority:  major    |  Milestone:  1.9.0
    Component:           |    Version:  1.8.2
  packaging              |   Keywords:  error usability packaging
   Resolution:           |  setuptools review-needed
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by davidsarah):

 +1 on both these patches, with suggestions:
  * use mock to patch {{{__builtins__['__import__']}}}
  * {{{traceback.extract_tb(etrace)[-1]}}} returns a tuple rather than a
 string, so the {{{comment}}} element won't have the same type as it has in
 other cases. "{{{str(traceback.extract_tb(etrace)[-1])}}}" would work (in
 which case the test only needs "{{{'wheeeyo' in stuff[2]}}}").
  * update "{{{# comment is the module name and message of the original
 ImportError}}}" to something like "{{{# comment is the stringified
 traceback entry for the original ImportError}}}"

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1389#comment:6>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage