[tahoe-lafs-trac-stream] [tahoe-lafs] #1429: automatically upload a file when it is put in a given local directory

[tahoe-lafs]

#1429: automatically upload a file when it is put in a given local directory
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  nejucomo
  davidsarah             |     Status:  assigned
         Type:           |  Milestone:  1.9.0
  enhancement            |    Version:  1.8.2
     Priority:  major    |   Keywords:  drop-upload inotify usability
    Component:  code-    |  review-needed
  frontend               |
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by nejucomo):

 In the {{{DropUploader}}} constructor there may be a race condition
 between:

 {{{
         if not self._local_path.isdir():
             raise AssertionError("The drop-upload local path %r was not an
 existing directory." % quote_output(local_dir))
 }}}

 -and later-

 {{{
         self._notifier.watch(self._local_path, mask=mask,
 callbacks=[self._notify])
 }}}

 What happens if {{{self._local_path}}} is deleted between these lines?
 Would it be better to catch and handle the error of {{{self._local_path}}}
 not existing in the call to {{{.watch}}} ?  (Would that call signal the
 error?)

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1429#comment:22>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage