[tahoe-lafs-trac-stream] [tahoe-lafs] #1385: stop respecting the pre-v1.3.0 configuration files

[tahoe-lafs]

#1385: stop respecting the pre-v1.3.0 configuration files
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:
         Type:           |     Status:  new
  enhancement            |  Milestone:  1.9.0
     Priority:  minor    |    Version:  1.8.2
    Component:  code-    |   Keywords:  docs configuration defaults
  nodeadmin              |  usability news-needed error
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by davidsarah):

 * keywords:  docs configuration defaults usability news-needed regression
     => docs configuration defaults usability news-needed error
 * owner:  davidsarah =>
 * status:  assigned => new
 * priority:  critical => minor


Comment:

 The regression seems to be fixed, but there's still the issue in
 comment:32 about the new test. Also the way in which the existence of old
 config files is reported is quite ugly, with an unnecessary traceback
 (which initially made me miss the message at the top):
 {{{
 STARTING '/home/davidsarah/tahoe/sparkly/intro'
 u"Found pre-Tahoe-LAFS-v1.3 configuration file:
 '/home/davidsarah/tahoe/sparkly/intro/introducer.furl'. See
 docs/historical/configuration.rst."
 Traceback (most recent call last):
   File "/usr/lib/python2.6/dist-packages/twisted/application/app.py", line
 626, in run
     runApp(config)
   File "/usr/lib/python2.6/dist-packages/twisted/scripts/twistd.py", line
 23, in runApp
     _SomeApplicationRunner(config).run()
   File "/usr/lib/python2.6/dist-packages/twisted/application/app.py", line
 374, in run
     self.application = self.createOrGetApplication()
   File "/usr/lib/python2.6/dist-packages/twisted/application/app.py", line
 439, in createOrGetApplication
     application = getApplication(self.config, passphrase)
 --- <exception caught here> ---
   File "/usr/lib/python2.6/dist-packages/twisted/application/app.py", line
 450, in getApplication
     application = service.loadApplication(filename, style, passphrase)
   File "/usr/lib/python2.6/dist-packages/twisted/application/service.py",
 line 390, in loadApplication
     application = sob.loadValueFromFile(filename, 'application',
 passphrase)
   File "/usr/lib/python2.6/dist-packages/twisted/persisted/sob.py", line
 210, in loadValueFromFile
     exec fileObj in d, d
   File "tahoe-introducer.tac", line 10, in <module>
     c = introducer.IntroducerNode()
   File
 "/home/davidsarah/tahoe/sparkly/src/allmydata/introducer/server.py", line
 19, in __init__
     node.Node.__init__(self, basedir)
   File "/home/davidsarah/tahoe/sparkly/src/allmydata/node.py", line 67, in
 __init__
     self.read_config()
   File "/home/davidsarah/tahoe/sparkly/src/allmydata/node.py", line 114,
 in read_config
     self.error_about_old_config_files()
   File "/home/davidsarah/tahoe/sparkly/src/allmydata/node.py", line 134,
 in error_about_old_config_files
     raise OldConfigError(oldfnames)
 allmydata.node.OldConfigError:
 set([u'/home/davidsarah/tahoe/sparkly/intro/introducer.furl'])

 Failed to load application:
 set([u'/home/davidsarah/tahoe/sparkly/intro/introducer.furl'])
 }}}

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1385#comment:34>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage