[tahoe-lafs-trac-stream] [tahoe-lafs] #1385: stop respecting the pre-v1.3.0 configuration files (improve error message)

[tahoe-lafs]

#1385: stop respecting the pre-v1.3.0 configuration files (improve error message)
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:
         Type:  defect   |     Status:  new
     Priority:  minor    |  Milestone:  1.9.0
    Component:  code-    |    Version:  1.8.2
  nodeadmin              |   Keywords:  docs configuration defaults
   Resolution:           |  usability news-needed error review-needed
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by davidsarah):

 * keywords:  docs configuration defaults usability news-needed error =>
     docs configuration defaults usability news-needed error review-needed


Comment:

 With [attachment:improve-old-config-error-message.darcs.patch], the error
 looks like:
 {{{
 STARTING '/home/davidsarah/.tahoe'
 Traceback (most recent call last):
   File "/usr/lib/python2.6/dist-packages/twisted/application/app.py", line
 626, in run
     runApp(config)
   File "/usr/lib/python2.6/dist-packages/twisted/scripts/twistd.py", line
 23, in runApp
     _SomeApplicationRunner(config).run()
   File "/usr/lib/python2.6/dist-packages/twisted/application/app.py", line
 374, in run
     self.application = self.createOrGetApplication()
   File "/usr/lib/python2.6/dist-packages/twisted/application/app.py", line
 439, in createOrGetApplication
     application = getApplication(self.config, passphrase)
 --- <exception caught here> ---
   File "/usr/lib/python2.6/dist-packages/twisted/application/app.py", line
 450, in getApplication
     application = service.loadApplication(filename, style, passphrase)
   File "/usr/lib/python2.6/dist-packages/twisted/application/service.py",
 line 390, in loadApplication
     application = sob.loadValueFromFile(filename, 'application',
 passphrase)
   File "/usr/lib/python2.6/dist-packages/twisted/persisted/sob.py", line
 210, in loadValueFromFile
     exec fileObj in d, d
   File "tahoe-client.tac", line 10, in <module>
     c = client.Client()
   File "/home/davidsarah/tahoe/sparkly/src/allmydata/client.py", line 134,
 in __init__
     node.Node.__init__(self, basedir)
   File "/home/davidsarah/tahoe/sparkly/src/allmydata/node.py", line 73, in
 __init__
     self.read_config()
   File "/home/davidsarah/tahoe/sparkly/src/allmydata/node.py", line 120,
 in read_config
     self.error_about_old_config_files()
   File "/home/davidsarah/tahoe/sparkly/src/allmydata/node.py", line 141,
 in error_about_old_config_files
     raise e
 allmydata.node.OldConfigError: Found pre-Tahoe-LAFS-v1.3 configuration
 file(s):
 '/home/davidsarah/.tahoe/webport'
 See docs/historical/configuration.rst.

 Failed to load application: Found pre-Tahoe-LAFS-v1.3 configuration
 file(s):
 '/home/davidsarah/.tahoe/webport'
 See docs/historical/configuration.rst.
 }}}

 The stack trace is still there, but at least it prints a sensible message
 at the end.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1385#comment:37>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage