[tahoe-lafs-trac-stream] [tahoe-lafs] #1469: new random introducer port on each start

tahoe-lafs trac at tahoe-lafs.org
Sat Aug 6 17:53:06 PDT 2011


#1469: new random introducer port on each start
-------------------------+-------------------------------------------------
     Reporter:  T_X      |      Owner:  davidsarah
         Type:  defect   |     Status:  closed
     Priority:           |  Milestone:  1.9.0
  critical               |    Version:  1.8.2
    Component:  code     |   Keywords:  introducer port random regression
   Resolution:  fixed    |  reviewed
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by davidsarah):

 Replying to [comment:5 zooko]:
 > Good patch! The only thing I might possibly do different is that this
 method named [http://tahoe-lafs.org/trac/tahoe-lafs/attachment/ticket/1469
 /all-including-cleanups-1469.darcs.patch#L352 _remove] is redundant with
 (but probably better than)
 [source:trunk/src/allmydata/util/fileutil.py?annotate=blame&rev=4957#L221
 fileutil.remove_if_possible]. Anyway: +1

 I changed it to use {{{fileutil.remove}}}, which is exactly what is
 needed. (Fail if the file doesn't get removed, but succeed if it didn't
 exist to start with or was removed concurrently.)

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1469#comment:9>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage


More information about the tahoe-lafs-trac-stream mailing list