[tahoe-lafs-trac-stream] [tahoe-lafs] #1484: CLI: overzealous quoting of error messages

[tahoe-lafs]

#1484: CLI: overzealous quoting of error messages
-------------------------------+-----------------------
 Reporter:  davidsarah         |          Owner:
     Type:  defect             |         Status:  new
 Priority:  major              |      Milestone:  soon
Component:  code-frontend-cli  |        Version:  1.8.2
 Keywords:  error quoting      |  Launchpad Bug:
-------------------------------+-----------------------
 When the CLI prints error messages from the gateway (mainly, but not
 always, in [source:src/allmydata/scripts/common_http.py at 4538#L74
 format_http_error]), it does so using {{{quote_output(message,
 quotemarks=False)}}}. This would be correct if the message were expected
 to be a single line, but since it is usually multi-line, the LFs are
 treated as control characters and escaped as {{{\x0a}}}. For example:

 {{{
 Error: 500 Internal Server Error
 "Traceback (most recent call last):\x0aFailure:
 allmydata.mutable.common.UncoordinatedWriteError: \x0a"
 }}}
 instead of the intended (albeit still ugly for other reasons):
 {{{
 Error: 500 Internal Server Error
 Traceback (most recent call last):
 Failure: allmydata.mutable.common.UncoordinatedWriteError:
 }}}

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1484>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage