[tahoe-lafs-trac-stream] [tahoe-lafs] #1425: blacklist support

[tahoe-lafs]

#1425: blacklist support
-----------------------------------+-------------------------------------
     Reporter:  warner             |      Owner:  davidsarah
         Type:  enhancement        |     Status:  new
     Priority:  major              |  Milestone:  1.9.0
    Component:  code-frontend-web  |    Version:  1.8.2
   Resolution:                     |   Keywords:  blacklist review-needed
Launchpad Bug:                     |
-----------------------------------+-------------------------------------

Comment (by davidsarah):

 Replying to [comment:11 warner]:
 > While testing, I noticed that doing the check in {{{NodeMaker}}} means
 that listing a directory will fail if one of the objects inside it is
 prohibited: the directory-listing code creates a Filenode for each object
 (to extract the readcaps/writecaps separately, I think), and that step
 fails. Should we fix that? By doing the check somewhere else (maybe
 Filenode.read?) we could allow directories to mention the prohibited item,
 which might be a usability win.

 Yes, I think we should fix this (and have a test for it).

 Would moving the check to Filenode.read be sufficient? I think you need
 checks in !MutableFileVersion as well (for both reading and writing a
 blacklisted mutable object). It seems more fragile than doing the check in
 !NodeMaker; there are more places to check, and missing one would leave
 some blacklisted objects accessible.

 Maybe it's safer to keep the check in !NodeMaker, but have the directory-
 reading code catch the exception and omit the blacklisted Filenode. Oh,
 but that would mean that modifying a directory would drop all blacklisted
 children, which is probably not what we want (the fact that the object is
 blacklisted for ''this'' gateway doesn't mean that it shouldn't be
 preserved for access via other gateways).

 I don't know; I'll leave it up to you.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1425#comment:12>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage