[tahoe-lafs-trac-stream] [tahoe-lafs] #1425: blacklist support

[tahoe-lafs]

#1425: blacklist support
-----------------------------------+--------------------------------
     Reporter:  warner             |      Owner:  davidsarah
         Type:  enhancement        |     Status:  new
     Priority:  major              |  Milestone:  1.9.0
    Component:  code-frontend-web  |    Version:  1.8.2
   Resolution:                     |   Keywords:  blacklist reviewed
Launchpad Bug:                     |
-----------------------------------+--------------------------------
Changes (by davidsarah):

 * keywords:  blacklist review-needed => blacklist reviewed


Comment:

 The scope of the try/except at line 26 of blacklist.py can be narrowed a
 bit; I'd put it around the {{{for}}} loop rather than the {{{if}}}.

 This comment still applies:
 > The line wrapping changes to {{{create_node_from_uri}}} are not
 necessary; I don't object to them but they probably shouldn't be in this
 patch.

 In allmydata/test/no_network.py, the line
 {{{c.set_default_mutable_keysize(522)}}} will conflict with
 [5171/ticket393-MDMF-2].

 In {{{test_blacklist}}}:
 {{{
 self.g.clients[0].blacklist.last_mtime -= 2.0
 }}}
 Ugh, but I can't think of a cleaner way to do this, so I'll let you off
 ;-)

 Good tests. Do we need a test that mutable files are correctly
 blacklisted? I suppose that's not necessary if we are checking in
 {{{NodeMaker}}}, but it would be if we were checking in
 immutable/filenode.py and mutable/filenode.py.

 Otherwise +1.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1425#comment:16>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage