[tahoe-lafs-trac-stream] [tahoe-lafs] #1425: blacklist support
tahoe-lafs
trac at tahoe-lafs.org
Tue Aug 23 17:14:09 PDT 2011
#1425: blacklist support
-----------------------------------+--------------------------------
Reporter: warner | Owner: warner
Type: enhancement | Status: new
Priority: major | Milestone: 1.9.0
Component: code-frontend-web | Version: 1.8.2
Resolution: | Keywords: blacklist reviewed
Launchpad Bug: |
-----------------------------------+--------------------------------
Comment (by warner):
hrm, one wrinkle that's somehow bypassing tests meant to catch it: if you
blacklist a file, access it (and get the error), then unblacklist it, the
next access still throws an error. An obvious downside of monkeypatching
to replace {{{Node.read}}} is that the Node might stick around: in this
case in the nodemaker's cache (although that's a {{{WeakValueDictionary}}}
so there must be something else holding on to it).
The safest approach (at least one that would let you unblacklist things
quickly) would be to do the blacklist check on each call to read(), rather
than replacing read() with a function that always throws an exception.
--
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1425#comment:19>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage
More information about the tahoe-lafs-trac-stream
mailing list