[tahoe-lafs-trac-stream] [tahoe-lafs] #1425: blacklist support

[tahoe-lafs]

#1425: blacklist support
-----------------------------------+-------------------------------------
     Reporter:  warner             |      Owner:  warner
         Type:  enhancement        |     Status:  new
     Priority:  major              |  Milestone:  1.9.0
    Component:  code-frontend-web  |    Version:  1.8.2
   Resolution:                     |   Keywords:  blacklist review-needed
Launchpad Bug:                     |
-----------------------------------+-------------------------------------

Comment (by warner):

 [attachment:blacklist4.darcs.patch] : the blacklist.py file is missing,
 including the new {{{ProhibitedNode}}} class, so I can't test it right
 away. I assume the new class passes through a lot of methods but raises
 an exception during {{{read()}}} and {{{download_version}}} (and
 {{{download_best_version}}}).

 Let's move the {{{no_network.py}}} cleanups to a different patch:
 they're useful cleanups, but I agree it'd be better to defer them until
 after the release.

 I'm willing to go with this approach, if only for expediency.. I've got
 a few concerns that might warrant more work post-1.9:

 * we talked about this blocking FTP/SFTP too, and blocking {{{read()}}}
   ought to do that, but it'd be nice to have a test for it.
 * marking the files as prohibited on the directory listing is a nice
   touch, but I'd be happy to see this feature go in without it. Also, by
   removing the More Info link, it's harder for users to find the blocked
   filecap (and in particular the storage-index), so they can edit their
   {{{access.blacklist}}} file to unblock the file later. Maybe we could
   put "Access Prohibited" in the info column and make it a link to the
   same old More Info page as before, then add the reason to the
   more-info page? Likewise, I don't think we need to change the "type"
   column to indicate the file has been blacklisted: the strikethrough is
   plenty big enough.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1425#comment:22>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage