[tahoe-lafs-trac-stream] [tahoe-lafs] #1628: UCWE on deep check with recent version

[tahoe-lafs]

#1628: UCWE on deep check with recent version
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  kevan
  davidsarah             |     Status:  assigned
         Type:  defect   |  Milestone:  1.9.1
     Priority:           |    Version:  1.9.0
  critical               |   Keywords:  tahoe-check verify ucwe regression
    Component:  code     |  review-needed
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by warner):

 kevan: can you double-check that I got that delta right? I *think* the
 only part that changed was this bit:

 {{{
         all_shnums = filter(lambda sh: len(self.writers[sh]) > 0,
                             self.writers.iterkeys())
         if len(all_shnums) < self.required_shares or self.surprised:
             return self._failure()
 }}}

 with which I fully concur. Since empty lists are falsey, you could also
 express it like:

 {{{
 all_shnums = set([shnum for shnum in self.writers if self.writers[shnum]])
 # or
 all_shnums = set([shnum for shnum,writers in self.writers.items() if
 writers])
 # or, relying upon the uniqueness of dict keys:
 all_shnums = [shnum for shnum,writers in self.writers.items() if writers]
 # or, since we only actually care about the count of unique shnums:
 shares = len([shnum for shnum,writers in self.writers.items() if writers])
 }}}

 (also, be aware of the {{{DictOfSets}}} that I use in the immutable code
 for tracking the shnum->servers mapping)

 Should I leave this ticket open until we get that second test written?

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1628#comment:23>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage