[tahoe-lafs-trac-stream] [tahoe-lafs] #1628: UCWE on deep check with recent version

[tahoe-lafs]

#1628: UCWE on deep check with recent version
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  kevan
  davidsarah             |     Status:  assigned
         Type:  defect   |  Milestone:  1.9.1
     Priority:           |    Version:  1.9.0
  critical               |   Keywords:  tahoe-check verify ucwe regression
    Component:  code     |  review-needed
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by kevan):

 I altered {{{test_multiply_placed_shares}}} to fail if some of the shares
 aren't updated to the newest version on an update, so we don't need to
 wait for another test. I guess the git changelogs are a little stale;
 sorry for any confusion from that.

 You caught the only important change with your delta. I also removed

 {{{
         self.g.clients[0].DEFAULT_ENCODING_PARAMETERS['n'] = 75
 }}}

 from {{{test_multiply_placed_shares}}}. Placing a lot of shares (so each
 server holds a few shares) made the test yield an UCWE more reliably, but
 it still sometimes made it to the multiple version check due to #1641. It
 didn't seem worthwhile to set a magical encoding parameter if it didn't
 always work, and the test always failed without the fix in any case, so I
 took it out. It probably doesn't matter either way, but the test might be
 a little faster without that line.

 Thanks for the review, the suggested alternatives, and for landing the
 fixes.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1628#comment:24>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage