[tahoe-lafs-trac-stream] [tahoe-lafs] #1593: the drop-upload dircap should be in BASEDIR/private/

[tahoe-lafs]

#1593: the drop-upload dircap should be in BASEDIR/private/
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:  davidsarah
         Type:  defect   |     Status:  new
     Priority:  major    |  Milestone:  1.9.1
    Component:  code     |    Version:  1.9.0
   Resolution:           |   Keywords:  configuration security forward-
Launchpad Bug:           |  compatibility
-------------------------+-------------------------------------------------
Changes (by zooko):

 * keywords:  configuration security review-needed => configuration security
     forward-compatibility
 * owner:  zooko => davidsarah
 * milestone:  1.10.0 => 1.9.1


Comment:

 I reviewed https://tahoe-lafs.org/~davidsarah/patches/fix-test-
 doc-1593.darcs.patch . I think before this patch omitting the
 {{{local.directory}}} configuration would cause the drop-uploader to
 silently not start, and after this patch, omitting it will cause an
 {{{AttributeError}}} exception when the {{{local_dir_utf8}}} argument to
 [source:git/src/allmydata/frontends/drop_upload.py?annotate=blame&rev=c102056ac1df178414acc8ae909fdcdc3c2dea98#L18
 DropUploader] is {{{None}}}.

 Other than that, I see no problems with this patch.

 Now, that isn't so important and maybe we could just land the patch as is.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1593#comment:3>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage