[tahoe-lafs-trac-stream] [tahoe-lafs] #1366: avoid calling req.finish() on closed HTTP connections

[tahoe-lafs]

#1366: avoid calling req.finish() on closed HTTP connections
-------------------------------+--------------------------------------------
 Reporter:  warner             |           Owner:           
     Type:  defect             |          Status:  new      
 Priority:  major              |       Milestone:  undecided
Component:  code-frontend-web  |         Version:  1.8.2    
 Keywords:                     |   Launchpad Bug:           
-------------------------------+--------------------------------------------
 While reviewing #393 MDMF, I ran into some test failures which were
 related to an HTTP "GET" connection being closed by the client before the
 tahoe server had a chance to close it itself. I think it only occurs
 during the new tests added as part of the #393 patch, but it's not MDMF-
 specific.

 Here's a patch to fix it. Note that Twisted-9.0 was the first version
 which started raising an error when you call {{{request.finish()}}} on a
 request that's already been closed, and it was also the first version to
 offer {{{request.notifyFinish()}}} to tell you when it's been closed. So
 this patch has to switch on {{{hasattr(req, "notifyFinish")}}} until the
 time we raise our dependency on Twisted to 9.0 or later.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1366>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage