[tahoe-lafs-trac-stream] [tahoe-lafs] #1363: refactor storage_client.py, use IServer objects instead of rrefs

[tahoe-lafs]

#1363: refactor storage_client.py, use IServer objects instead of rrefs
------------------------+---------------------------------------------------
     Reporter:  warner  |       Owner:  zooko        
         Type:  task    |      Status:  new          
     Priority:  major   |   Milestone:  undecided    
    Component:  code    |     Version:  1.8.2        
   Resolution:          |    Keywords:  review-needed
Launchpad Bug:          |  
------------------------+---------------------------------------------------

Comment (by davidsarah):

 Reviewing:
 * +1 on "test_client.py, upload.py:: remove KiB/MiB/etc constants, and
 other dead code". I like negative-code patches :-)
 * +1 on "storage_client.py: clean up test_add_server/test_add_descriptor,
 remove .test_servers"
 * +1 on "upload.py: more tracker-vs-server cleanup", with a nitpick that
 "to a set of serverids which claim to already have the share" should be
 "to a set of serverids for servers that claim to already have the share".

 "already_servers" should be "already_serverids".

 "contacted_servers" and "contacted_servers2" aren't very good variable
 names. I suggest s/contacted_servers/worth_asking_servers/ and
 s/contacted_servers2/have_asked_servers/, and similarly for trackers.

 Will look at the rest of the patch tomorrow.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1363#comment:11>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage