[tahoe-lafs-trac-stream] [tahoe-lafs] #1363: refactor storage_client.py, use IServer objects instead of rrefs

[tahoe-lafs]

#1363: refactor storage_client.py, use IServer objects instead of rrefs
------------------------+---------------------------------------------------
     Reporter:  warner  |       Owner:  davidsarah   
         Type:  task    |      Status:  assigned     
     Priority:  major   |   Milestone:  undecided    
    Component:  code    |     Version:  1.8.2        
   Resolution:          |    Keywords:  review-needed
Launchpad Bug:          |  
------------------------+---------------------------------------------------

Comment (by warner):

 heh, one step at a time. I'll add those other peer->server items to the
 TODO list, though.

 Yeah, I don't particularly like name/longname either. I'm using
 {{{name()}}} as a short placeholder until I figure out what the method
 really wants to be called: my goal was to turn {{{base32.b2a(serverid)}}}
 and {{{idlib.shortnodeid_b2a(serverid)}}} into something like
 {{{s.name()}}}, and I was previously using {{{s.get_short_description()}}}
 which didn't exactly roll off the tongue. {{{s.get_name()}}} sounds
 better, but I'm wondering if something even more descriptive might show up
 once it's only ever being used in log.msg and webapi-display contexts.

 But I'll add a patch to use {{{get_name()/get_longname()}}} for now, I
 only see about 30 uses of it.

 And on {{{.serverid}}}, I don't think so, but I'm putting off removing
 that until I remove {{{get_serverid}}} too, since the goal is to redefine
 the concept of "serverid" altogether:

 * step one: change as much as possible to use more accurate properties
 like "server permutation seed", "lease secret seed", and human-display-
 friendly names.
 * step two: remove {{{.serverid/.get_serverid()}}} and fix what breaks.
 * step three: enjoy brief moment of peace while "serverid" is safely
 banished
 * step four: re-introduce the term to mean "public key which signed the
 server's Introducer announcement", since I think that's the best claimant
 to the term "serverid", and I don't want to switch the semantics until I'm
 sure there are no remaining users of the old form.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1363#comment:15>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage