[tahoe-lafs-trac-stream] [tahoe-lafs] #730: unify Windows and non-Windows "make quicktest"

[tahoe-lafs]

#730: unify Windows and non-Windows "make quicktest"
------------------------------------+---------------------------------------
     Reporter:  zooko               |       Owner:  zooko               
         Type:  defect              |      Status:  closed              
     Priority:  minor               |   Milestone:  1.7.0               
    Component:  dev-infrastructure  |     Version:  1.4.1               
   Resolution:  fixed               |    Keywords:  windows test cleanup
Launchpad Bug:                      |  
------------------------------------+---------------------------------------

Comment (by davidsarah):

 Actually for the use in {{{make quicktest}}} and {{{make quicktest-
 coverage}}}, it was incorrect to make the change in [3910] (I was wrong
 about that in comment:4), because it would have caused the make command to
 exit leaving the test running. Probably no-one noticed because they don't
 use the Makefile on Windows, since it requires gmake.

 Anyway, [4927/ticket1306] fixes that, because {{{bin\tahoe.pyscript}}}
 doesn't use {{{os.execve}}}. The optimization that was made in [3891] is
 applicable to {{{bin/tahoe}}}, but it would have to fall back to
 {{{subprocess.call}}} on Windows. (This optimization should not be made in
 1.8.2 since it is a potentially destabilizing change. I'd rather get rid
 of the extra subprocess completely on all platforms by munging
 {{{sys.path}}} instead of setting PYTHONPATH.)

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/730#comment:7>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage