[tahoe-lafs-trac-stream] [tahoe-lafs] #1296: 'tahoe debug trial' command

[tahoe-lafs]

#1296: 'tahoe debug trial' command
-----------------------------------+----------------------------------------
     Reporter:  davidsarah         |       Owner:  davidsarah                       
         Type:  defect             |      Status:  assigned                         
     Priority:  major              |   Milestone:  1.8.2                            
    Component:  code-frontend-cli  |     Version:  1.8.1                            
   Resolution:                     |    Keywords:  bbfreeze setuptools review-needed
Launchpad Bug:                     |  
-----------------------------------+----------------------------------------

Comment (by warner):

 my review:

 * please add trailing newlines to {{{docs/frontends/CLI.rst}}}
 and{{{src/allmydata/test/trialtest.py}}}
 * {{{SystemTest.test_debug_trial}}} fails on my system (with
 twisted-10.2). I suspect that trial's output has changed in 10.2, you may
 need to be less strict in matching the output:

 {{{
 56:warner at Cookies% trial --version
 Twisted version: 10.2.0
 57:warner at Cookies% ./bin/tahoe debug trial allmydata.test.trialtest
 allmydata.test.trialtest
   Failure
     test_deferred_error ...
 [ERROR]
     test_error ...
 [ERROR]
     test_fail ...
 [FAIL]
   Success
     test_skip ...
 [SKIPPED]
     test_succeed ...
 [OK]
     test_todo ...
 [TODO]

 ===============================================================================
 [SKIPPED]
 skip

 allmydata.test.trialtest.Success.test_skip
 ===============================================================================
 [TODO]
 Reason: 'never mind'
 Traceback (most recent call last):
   File "/Users/warner2/stuff/tahoe/trunk/src/allmydata/test/trialtest.py",
 line 18, in test_todo
     self.fail('umm')
 twisted.trial.unittest.FailTest: umm

 allmydata.test.trialtest.Success.test_todo
 ===============================================================================
 [FAIL]
 Traceback (most recent call last):
   File "/Users/warner2/stuff/tahoe/trunk/src/allmydata/test/trialtest.py",
 line 24, in test_fail
     self.fail('fail')
 twisted.trial.unittest.FailTest: fail

 allmydata.test.trialtest.Failure.test_fail
 ===============================================================================
 [ERROR]
 Traceback (most recent call last):
 Failure: exceptions.AssertionError: screech

 allmydata.test.trialtest.Failure.test_deferred_error
 ===============================================================================
 [ERROR]
 Traceback (most recent call last):
   File "/Users/warner2/stuff/tahoe/trunk/src/allmydata/test/trialtest.py",
 line 27, in test_error
     raise AssertionError('clang')
 exceptions.AssertionError: clang

 allmydata.test.trialtest.Failure.test_error
 -------------------------------------------------------------------------------
 Ran 6 tests in 0.034s

 FAILED (skips=1, expectedFailures=1, failures=1, errors=2, successes=1)
 58:warner at Cookies%
 }}}

 Apart from that, it looks awesome. If you can confirm a trial-10.2 fix
 (you might want to check older versions of Twisted too, back to whatever
 minimum we support), go ahead and land it.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1296#comment:19>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage