[tahoe-lafs-trac-stream] [tahoe-lafs] #1326: don't require newer foolscap if you have older Twisted

[tahoe-lafs]

#1326: don't require newer foolscap if you have older Twisted
---------------------------+------------------------------------------------
     Reporter:  zooko      |       Owner:  davidsarah                         
         Type:  defect     |      Status:  closed                             
     Priority:  major      |   Milestone:  1.8.2                              
    Component:  packaging  |     Version:  1.8.1                              
   Resolution:  wontfix    |    Keywords:  setuptools install foolscap twisted
Launchpad Bug:             |  
---------------------------+------------------------------------------------
Changes (by davidsarah):

  * status:  new => closed
  * resolution:  => wontfix


Comment:

 It turned out to be much more difficult than I or zooko had thought to
 make the foolscap requirement dependent on the installed version of
 Twisted.

 The problem is that:
 * the first import of either {{{pkg_resources}}} or {{{setuptools}}} in
 [source:setup.py] must be after {{{__requires__}}} has been set (because
 that import has side effects on the {{{sys.path}}} that depend on
 {{{__requires__}}});
 * {{{__requires__}}} is set from the requirements computed by
 [source:src/allmydata/_auto_deps.py] (loaded using {{{execfile}}});
 * if {{{_auto_deps.py}}} imports {{{pkg_resources}}} in order to get the
 version of Twisted (for the current working set), then that first import
 would have to be both before ''and'' after setting {{{__requires__}}}:
 contradiction.

 If {{{_auto_deps.py}}} were to import {{{twisted}}} directly, OTOH, that
 wouldn't necessarily be the same Twisted version that would later be
 imported at run time.

 So we decided to just require {{{foolscap >= 0.6.1}}} instead. The
 difference between 0.6.0 and 0.6.1 is to quiet a !DeprecationWarning
 (#1329).

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1326#comment:7>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage