[tahoe-lafs-trac-stream] [tahoe-lafs] #1286: test failures with message "exceptions.AttributeError: 'StreamServerEndpointService' object has no attribute '_port'", and failure to write node.url file with Twisted 10.2

[tahoe-lafs]

#1286: test failures with message "exceptions.AttributeError:
'StreamServerEndpointService' object has no attribute '_port'", and failure
to write node.url file with Twisted 10.2
----------------------------+-----------------------------------------------
     Reporter:  davidsarah  |       Owner:  warner                                
         Type:  defect      |      Status:  closed                                
     Priority:  major       |   Milestone:  1.8.2                                 
    Component:  code        |     Version:  1.8.1                                 
   Resolution:  fixed       |    Keywords:  twisted test news-needed review-needed
Launchpad Bug:              |  
----------------------------+-----------------------------------------------

Comment (by Brian Warner <warner@…>):

 In [4979/ticket1306]:
 {{{
 #!CommitTicketReference repository="ticket1306" revision="4979"
 Tolerate Twisted-10.2's endpoints, patch by David-Sarah. Closes #1286.

 The service generated by strports.service() changed in 10.2, and the ugly
 private-attribute-reading hack we used to glean a kernel-allocated port
 number (e.g. when using "tcp:0", especially during unit tests) broke,
 causing
 Tahoe to be completely unusable with Twisted-10.2 . The new ugly
 private-attribute-reading hack starts by figuring out what sort of service
 was generated, then reads different attributes accordingly.

 This also hushes a warning when using schemeless strports strings like "0"
 or
 "3456", by quietly prepending a "tcp:" scheme, since 10.2 complains about
 those. It also adds getURL() and getPortnum() accessors to the "webish"
 service, rather than having unit tests dig through _url and _portnum and
 such
 to find out what they are.
 }}}

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1286#comment:16>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage