#1342: post-1.8.2 clean-up
-----------------------------+----------------------------------------------
Reporter: zooko | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone: 1.9.0
Component: unknown | Version: 1.8.1
Resolution: | Keywords: cleanup review-needed
Launchpad Bug: |
-----------------------------+----------------------------------------------
Comment (by davidsarah):
Reviewing attachment:improved-package-tests.darcs.patch :
{{{test-dont-install-newer-dep-when-you-already-have-sufficiently-new-
one.py}}} is way too long a filename. Also the test is about which dist is
''built'' and tested (by {{{setup.py test}}}) when an existing one is
installed, not about whether the new dist is installed. (It should be
"dist", not "dep", since we're talking about a particular version/build.)
How about {{{test-be-satisfied-with-new-enough-dist.py}}}?
{{{test-dont-use-too-old-dep.py}}} (which should be {{{test-dont-use-too-
old-dist.py}}}) has this:
{{{
# The goal is to turn red if the build system tries to use the
# source dist when it could have used the binary dist.
}}}
which I think is a stale comment from a different test.
--
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1342#comment:4>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage