[tahoe-lafs-trac-stream] [tahoe-lafs] #1384: use storage/shares/ instead of storage/ to detect available space

[tahoe-lafs]

#1384: use storage/shares/ instead of storage/ to detect available space
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:  davidsarah
         Type:  defect   |     Status:  assigned
     Priority:  minor    |  Milestone:  1.9.0
    Component:  code-    |    Version:  1.8.2
  nodeadmin              |   Keywords:  usability configuration defaults
   Resolution:           |  storage review-needed test-needed
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by davidsarah):

 Replying to [comment:3 davidsarah]:
 > We could, and probably should, test this by mocking
 {{{fileutil.get_disk_stats}}}, and checking that the server reports the
 correct space and accepts/refuses immutable shares correctly.

 Actually to test this patch, we only need to mock
 {{{fileutil.get_disk_stats}}} to check that it is called with the correct
 directory. We're short of time to write the test, and this approach is
 simpler.

 Note that the NEWS patch says "This allows storage/shares/, rather than
 storage/, to be a symlink to another filesystem.". Per T_X's comment:4, it
 should say "... to be the mount point for another filesystem."

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1384#comment:5>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage