[tahoe-lafs-trac-stream] [tahoe-lafs] #1384: use storage/shares/ instead of storage/ to detect available space

[tahoe-lafs]

#1384: use storage/shares/ instead of storage/ to detect available space
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:
         Type:  defect   |     Status:  new
     Priority:  minor    |  Milestone:  1.9.0
    Component:  code-    |    Version:  1.8.2
  nodeadmin              |   Keywords:  usability configuration defaults
   Resolution:           |  storage review-needed
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by davidsarah):

 * keywords:  usability configuration defaults storage review-needed test-
     needed => usability configuration defaults storage review-needed
 * owner:  davidsarah =>
 * status:  assigned => new


Comment:

 Replying to [comment:5 davidsarah]:
 > Replying to [comment:3 davidsarah]:
 > > We could, and probably should, test this by mocking
 {{{fileutil.get_disk_stats}}}, and checking that the server reports the
 correct space and accepts/refuses immutable shares correctly.
 >
 > Actually to test this patch, we only need to mock
 {{{fileutil.get_disk_stats}}} to check that it is called with the correct
 directory. We're short of time to write the test, and this approach is
 simpler.

 I ended up implementing the more comprehensive test, but excluding the
 check that we accept/refuse immutable shares based on the remaining space.
 It does check that the {{{get_available_space}}} method of the
 {{{StorageServer}}} returns the right value.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1384#comment:6>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage