[tahoe-lafs-trac-stream] [tahoe-lafs] #1442: scp fails silently when copying to a Tahoe SFTP frontend; it should fail loudly

[tahoe-lafs]

#1442: scp fails silently when copying to a Tahoe SFTP frontend; it should fail
loudly
-------------------------------+------------------------------------------
     Reporter:  davidsarah     |      Owner:  kevan
         Type:  defect         |     Status:  assigned
     Priority:  major          |  Milestone:  1.9.0
    Component:  code-frontend  |    Version:  1.8.2
   Resolution:                 |   Keywords:  scp error sftp review-needed
Launchpad Bug:                 |
-------------------------------+------------------------------------------

Comment (by kevan):

 Good patches. A few comments:

   * Should the second line sent to the client in
 {{{ShellSession._unsupported}}} say the exact {{{df}}} invocation that it
 supports ({{{df -P -k /}}})? It'd be a bit confusing to a user that
 expected {{{df}}} used alone to work, since they'd see the same error
 message.
   * Should the tests test for the second line in
 {{{ShellSession._unsupported}}}?
   * Nitpick: the tests that look for the carriage returns you added only
 test for their presence somewhere in the output, even though we want the
 lines sent to the client to end with CRLFs. Making those tests more
 specific might detect, e.g., someone editing one of the two output lines
 for either {{{df}}} or {{{ShellSession._unsupported}}} and forgetting to
 add the CRLF at the end; as it is, the tests will pass so long as some
 line in the output retains its CRLF.

 The changes work fine with the OpenSSH {{{sftp}}} and {{{scp}}} programs
 on my system. It'd be interesting to see what they do on a popular Windows
 program, like WinSCP, but I don't have a Windows box here.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1442#comment:9>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage