[tahoe-lafs-trac-stream] [tahoe-lafs] #1149: scripts/webopen.py is not tested

tahoe-lafs trac at tahoe-lafs.org
Sun Jul 31 22:59:23 PDT 2011


#1149: scripts/webopen.py is not tested
----------------------------+----------------------------------------------
     Reporter:  davidsarah  |      Owner:  nejucomo
         Type:  defect      |     Status:  assigned
     Priority:  major       |  Milestone:  1.9.0
    Component:  code-       |    Version:  1.7.1
  frontend-cli              |   Keywords:  tahoe-webopen easy review-needed
   Resolution:              |
Launchpad Bug:              |
----------------------------+----------------------------------------------

Comment (by nejucomo):

 I read over the patch and understand the implementation.

 After applying the patch I can successfully run:

 {{{
 $ python ./setup.py test --suite allmydata.test.test_cli.Webopen
 }}}

 -after many messages about dependency management, the actual tests succeed
 and look like this:

 {{{
 allmydata.test.test_cli
   Webopen
     test_webopen ...
 [OK]
     test_webopen_with_nonexistent_alias ...
 [OK]

 -------------------------------------------------------------------------------
 Ran 2 tests in 0.664s

 PASSED (successes=2)
 }}}

 I therefore consider this patch good to merge because it only adds a
 unittest, which successfully passes, and which does not launch my
 webbrowser.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1149#comment:4>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage


More information about the tahoe-lafs-trac-stream mailing list