[tahoe-lafs-trac-stream] [tahoe-lafs] #1395: error doing a check --verify on files bigger than about 1Gbyte

[tahoe-lafs]

#1395: error doing a check --verify on files bigger than about 1Gbyte
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  zooko
  sickness               |     Status:  assigned
         Type:  defect   |  Milestone:  1.9.0
     Priority:  major    |    Version:  1.8.2
    Component:  code-    |   Keywords:  memory verify error performance
  encoding               |  review-needed
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by zooko):

 Okay, I've reviewed the patch and it is good. Please review this alternate
 patch — attachment:not-too-parallel-test-by-patching.diff — in which the
 test patches the !ValidatedReadBucketClass instead of the code under test
 (Checker) having code in it for testing purposes. Unfortunately this patch
 depends on a variant of {{{mock.py}}} named {{{mockutil.py}}} which knows
 what to do when a test case returns a Deferred instance, so I don't think
 we should commit this patch as is. I've submitted a patch to the
 {{{mock}}} project (http://code.google.com/p/mock/issues/detail?id=96 )
 and I'll proceed to work up a patch for Tahoe-LAFS which uses a lower-tech
 patching tool. But please review this patch because it most clearly shows
 why I like this approach. (If you ignore the whole {{{mockutil.py}}}
 part.)

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1395#comment:27>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage