[tahoe-lafs-trac-stream] [tahoe-lafs] #1559: in test_download.Corruption.test_each_byte, catalog_detection = True has bitrotted

[tahoe-lafs]

#1559: in test_download.Corruption.test_each_byte, catalog_detection = True has
bitrotted
----------------------------+-------------------------
     Reporter:  davidsarah  |      Owner:  somebody
         Type:  defect      |     Status:  new
     Priority:  minor       |  Milestone:  undecided
    Component:  code        |    Version:  1.8.2
   Resolution:              |   Keywords:  test bitrot
Launchpad Bug:              |
----------------------------+-------------------------
Description changed by davidsarah:

Old description:

> [source:src/allmydata/test/test_download.py
> test_download.Corruption.test_each_byte] has a disabled option that is
> described as follows:
> {{{
>         # Setting catalog_detection=True performs an exhaustive test of
> the
>         # Downloader's response to corruption in the lsb of each byte of
> the
>         # 2070-byte share, with two goals: make sure we tolerate all
> forms of
>         # corruption (i.e. don't hang or return bad data), and make a
> list of
>         # which bytes can be corrupted without influencing the download
>         # (since we don't need every byte of the share). That takes 50s
> to
>         # run on my laptop and doesn't have any actual asserts, so we
> don't
>         # normally do that.
> }}}
>
> Setting {{{catalog_detection = True}}} results in the exception:
> {{{
> [ERROR]: allmydata.test.test_download.Corruption.test_each_byte
>
> Traceback (most recent call last):
>   File
> "/home/davidsarah/tahoe/ticket999/src/allmydata/test/test_download.py",
> line 1019, in _uploaded
>     corrupt_me = [(i, "") for i in range(len(self.sh0_orig))]
> exceptions.AttributeError: 'Corruption' object has no attribute
> 'sh0_orig'
> }}}
>
> This happens also for the 1.8.2 release, so the bitrot must have occurred
> at some point before that. To close this ticket, either fix or remove the
> {{{catalog_detection}}} code.

New description:

 [source:src/allmydata/test/test_download.py at 5251#L941
 test_download.Corruption.test_each_byte] has a disabled option that is
 described as follows:
 {{{
         # Setting catalog_detection=True performs an exhaustive test of
 the
         # Downloader's response to corruption in the lsb of each byte of
 the
         # 2070-byte share, with two goals: make sure we tolerate all forms
 of
         # corruption (i.e. don't hang or return bad data), and make a list
 of
         # which bytes can be corrupted without influencing the download
         # (since we don't need every byte of the share). That takes 50s to
         # run on my laptop and doesn't have any actual asserts, so we
 don't
         # normally do that.
 }}}

 Setting {{{catalog_detection = True}}} results in the exception:
 {{{
 [ERROR]: allmydata.test.test_download.Corruption.test_each_byte

 Traceback (most recent call last):
   File
 "/home/davidsarah/tahoe/ticket999/src/allmydata/test/test_download.py",
 line 1019, in _uploaded
     corrupt_me = [(i, "") for i in range(len(self.sh0_orig))]
 exceptions.AttributeError: 'Corruption' object has no attribute 'sh0_orig'
 }}}

 This happens also for the 1.8.2 release, so the bitrot must have occurred
 at some point before that. To close this ticket, either fix or remove the
 {{{catalog_detection}}} code.

--

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1559#comment:1>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage