[tahoe-lafs-trac-stream] [tahoe-lafs] #1521: 'no attribute stopProducing' exception in new mutable Retrieve path

[tahoe-lafs]

#1521: 'no attribute stopProducing' exception in new mutable Retrieve path
--------------------------+-------------------------
 Reporter:  warner        |          Owner:
     Type:  defect        |         Status:  new
 Priority:  major         |      Milestone:  1.9.0
Component:  code-mutable  |        Version:  1.9.0a1
 Keywords:                |  Launchpad Bug:
--------------------------+-------------------------
 When downloading a mutable file, if the HTTP client disconnects early, an
 exception shows up in the node's logs/twistd.log:

 {{{
 2011-09-01 08:46:53-0700 [HTTPChannel,61,127.0.0.1] Unhandled Error
         Traceback (most recent call last):
           File "/Library/Python/2.6/site-
 packages/Twisted-10.2.0-py2.6-macosx-10.6-universal.egg/twisted/application/app.py",
 line 311, in runReactorWithLogging
             reactor.run()
           ...(elided boring stuff)...
           File "/Library/Python/2.6/site-
 packages/Twisted-10.2.0-py2.6-macosx-10.6-universal.egg/twisted/internet/posixbase.py",
 line 253, in _disconnectSelectable
             selectable.connectionLost(f)
           File "/Library/Python/2.6/site-
 packages/Twisted-10.2.0-py2.6-macosx-10.6-universal.egg/twisted/internet/tcp.py",
 line 513, in connectionLost
             abstract.FileDescriptor.connectionLost(self, reason)
           File "/Library/Python/2.6/site-
 packages/Twisted-10.2.0-py2.6-macosx-10.6-universal.egg/twisted/internet/abstract.py",
 line 157, in connectionLost
             self.producer.stopProducing()
         exceptions.AttributeError: Retrieve instance has no attribute
 'stopProducing'
 }}}

 It looks like the new MDMF downloader's Producer is missing some of the
 control-flow methods. The exception is invisible from the HTTP client
 (after all, it just disconnected), but it's noisy in the node, and might
 mean that the node keeps downloading the rest of the file even though
 nobody's listening anymore.

 We should really fix this for 1.9, as it probably shows up in SDMF
 downloads too. Not super critical, but more than nice-to-have.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1521>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage