[tahoe-lafs-trac-stream] [tahoe-lafs] #1534: Some docs in mutable/layout.py are slightly confusing.

[tahoe-lafs]

#1534: Some docs in mutable/layout.py are slightly confusing.
------------------------------+--------------------------------
     Reporter:  zancas        |      Owner:  kevan
         Type:  defect        |     Status:  new
     Priority:  minor         |  Milestone:  1.9.0
    Component:  code-mutable  |    Version:  1.9.0a1
   Resolution:                |   Keywords:  docs review-needed
Launchpad Bug:                |
------------------------------+--------------------------------

Comment (by davidsarah):

 I'm confused by something else: the headers seem to be different for SDMF
 and MDMF, but the comment describes the SDMF headers without saying so. It
 should probably be a comment associated with SDMFSlotWriteProxy, except
 that there are other functions outside that class that only support SDMF.

 Another thing; layout.py defines:
 {{{
 def unpack_checkstring(checkstring):
     cs_len = struct.calcsize(PREFIX)
     version, seqnum, root_hash, IV = struct.unpack(PREFIX,
 checkstring[:cs_len])
     if version != 0: # TODO: just ignore the share
         raise UnknownVersionError("got mutable share version %d, but I
 only understand version 0" % version)
     return (seqnum, root_hash, IV)
 }}}

 but it is called by [source:src/allmydata/mutable/publish.py at 5231#L1105]
 in a context that doesn't seem to be specific to SDMF. Why doesn't that
 raise an {{{UnknownVersionError}}}?

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1534#comment:3>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage