[tahoe-lafs-trac-stream] [tahoe-lafs] #1534: Some docs in mutable/layout.py are slightly confusing.

[tahoe-lafs]

#1534: Some docs in mutable/layout.py are slightly confusing.
------------------------------+--------------------------------
     Reporter:  zancas        |      Owner:  kevan
         Type:  defect        |     Status:  new
     Priority:  minor         |  Milestone:  1.9.0
    Component:  code-mutable  |    Version:  1.9.0a1
   Resolution:                |   Keywords:  docs review-needed
Launchpad Bug:                |
------------------------------+--------------------------------

Comment (by kevan):

 Replying to [comment:4 kevan]:
 > The caller in publish handles the case in which the remote write fails
 (e.g., because of an uncoordinated write error, share corruption, or
 something else). It's possible that we don't have tests to exercise that,
 or that the exception is getting lost in the deferred chain somewhere.
 I'll take a look at it.

 It seems that both of these contribute to the missing exception.
 attachment:1534-dropped-error-and-tests.darcs.patch (or attachment:1354
 -dropped-error-and-tests.darcs.patch, if you can tolerate the typo :-)
 tweaks the control flow in the publisher a little bit so the exceptions
 don't get hidden, and then adds a test to exercise the code for MDMF
 files. {{{UnknownVersionError}}} still doesn't get raised, though, since
 the MDMF checkstring is shorter than the SDMF checkstring and causes
 {{{struct.unpack}}} to give up before the version can be extracted and
 checked. I'll work on a patch to make the new test pass.

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1534#comment:5>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage