[tahoe-lafs-trac-stream] [tahoe-lafs] #393: mutable: implement MDMF

[tahoe-lafs]

#393: mutable: implement MDMF
-------------------------+-------------------------------------------------
     Reporter:  warner   |      Owner:  zooko
         Type:           |     Status:  new
  enhancement            |  Milestone:  1.9.0
     Priority:  major    |    Version:  1.1.0
    Component:  code-    |   Keywords:  newcaps performance random-access
  mutable                |  privacy gsoc mdmf mutable backward-
   Resolution:           |  compatibility forward-compatibility review-
Launchpad Bug:           |  needed
-------------------------+-------------------------------------------------
Changes (by davidsarah):

 * version:  1.0.0 => 1.1.0


Comment:

 At [source:src/allmydata/mutable/publish.py at 5280#L428], there is a comment
 about the {{{self.outstanding}}} set: "{{{the second table is our list}}}
 [sic] {{{of outstanding queries: those which are in flight and may or may
 not be delivered, accepted, or acknowledged. Items are added to this table
 when the request is sent, and removed when the response returns (or
 errbacks).}}}"

 However nothing in publish.py removes entries from {{{self.outstanding}}}.
 In finish_publishing at
 [source:src/allmydata/mutable/publish.py at 5280#L855], the loop adds entries
 to {{{self.outstanding}}}, and registers an errback to
 {{{self._connection_problem}}} if {{{writer.finish_publishing}}} fails.
 But {{{self._connection_problem}}} removes the writer from
 {{{self.writers}}}, it doesn't remove {{{(writer.peerid, writer.shnum)}}}
 from {{{self.outstanding}}}. So either the comment or the logic is wrong.
 (Also there's a reference to {{{_loop}}} at line 872, and I don't see any
 {{{_loop}}} in that file.)

-- 
Ticket URL: <http://tahoe-lafs.org/trac/tahoe-lafs/ticket/393#comment:165>
tahoe-lafs <http://tahoe-lafs.org>
secure decentralized storage