[tahoe-lafs-trac-stream] [tahoe-lafs] #1115: add servers-of-happiness to reports (post-repair says 10 hosts have good shares but there are only 4 hosts)

[tahoe-lafs]

#1115: add servers-of-happiness to reports (post-repair says 10 hosts have good
shares but there are only 4 hosts)
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:  davidsarah
         Type:  defect   |     Status:  assigned
     Priority:  major    |  Milestone:  1.11.0
    Component:  code-    |    Version:  1.7.0
  frontend-web           |   Keywords:  usability easy repair review-needed
   Resolution:           |  servers-of-happiness upload
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by amiller):

 * keywords:  usability easy repair test-needed servers-of-happiness upload
     => usability easy repair review-needed servers-of-happiness upload


Comment:

 Right now there are two conflicting definitions for computing {{{count-
 good-share-hosts}}}:

 1. in [https://tahoe-lafs.org/trac/tahoe-
 lafs/browser/trunk/src/allmydata/immutable/filenode.py?rev=5359#L125
 immutable/filenode.py], runs after a repair operation
 {{{
  prr.data['count-good-share-hosts'] = len(sm)
 }}}

 2. in [https://tahoe-lafs.org/trac/tahoe-
 lafs/browser/trunk/src/allmydata/immutable/checker.py?rev=5359#L760
 immutable/checker.py], which runs just when checking
 {{{
  d['count-good-share-hosts'] = len([s for s in servers.keys() if
 servers[s]])
 }}}

 So, I wrote a test for both of these conditions. Per comment:5 I'm
 providing a patch to fix the former (incorrect) one.

 https://github.com/amiller/tahoe-lafs/pull/4/files

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1115#comment:13>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage