[tahoe-lafs-trac-stream] [tahoe-lafs] #1115: add servers-of-happiness to reports (post-repair says 10 hosts have good shares but there are only 4 hosts)

[tahoe-lafs]

#1115: add servers-of-happiness to reports (post-repair says 10 hosts have good
shares but there are only 4 hosts)
-------------------------+-------------------------------------------------
     Reporter:  zooko    |      Owner:  davidsarah
         Type:  defect   |     Status:  assigned
     Priority:  major    |  Milestone:  1.11.0
    Component:  code-    |    Version:  1.7.0
  frontend-web           |   Keywords:  usability easy repair review-needed
   Resolution:           |  servers-of-happiness upload
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by davidsarah):

 {{{len(reduce(set.union, sm.itervalues()))}}} as used in the pull request
 is wrong for the empty map:
 {{{
 >>> reduce(set.union, [])
 Traceback (most recent call last):
   File "<stdin>", line 1, in <module>
 TypeError: reduce() of empty sequence with no initial value
 }}}

 {{{len(set(sm.itervalues()))}}} is correct. However, the docs should make
 clear that a high value of {{{count-good-share-hosts}}} does not imply
 good share distribution.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1115#comment:14>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage