[tahoe-lafs-trac-stream] [tahoe-lafs] #1240: add functional test of ResponseCache

[tahoe-lafs]

#1240: add functional test of ResponseCache
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  zooko
  davidsarah             |     Status:  assigned
         Type:  defect   |  Milestone:  1.11.0
     Priority:  major    |    Version:  1.8.0
    Component:  code-    |   Keywords:  review-needed test-needed mutable
  mutable                |  cache
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by amiller):

 * keywords:  review-needed mutable cache => review-needed test-needed
     mutable cache


Comment:

 This commit removes !ResponseCache. Instead, the !MDMFSlotReadProxys
 created by !ServerMap are kept around as instance variables. Retrieve is
 able to access these rather than creating its own instance. As a result,
 the {{{MDMFSlotReadProxy._data}}} cache obviates the need for the
 additional logic of !ResponseCache.

 Notably, by removing some logic that produces false cache misses, (https
 ://tahoe-lafs.org/trac/tahoe-
 lafs/browser/trunk/src/allmydata/mutable/retrieve.py?rev=5453#L293) the
 number of cache misses reduces from 84 to 60 in {{{test_deepcheck_mdmf}}}.

 https://github.com/amiller/tahoe-
 lafs/commit/cbdfb002a4bd8d16ec3b3faa608cfeb9e6325bfd

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1240#comment:8>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage