[tahoe-lafs-trac-stream] [tahoe-lafs] #1721: introducer: WrapV1SubscriberInV2Interface instance has no attribute 'tracker'
tahoe-lafs
trac at tahoe-lafs.org
Tue Apr 24 05:40:05 UTC 2012
#1721: introducer: WrapV1SubscriberInV2Interface instance has no attribute
'tracker'
------------------------------+-----------------------------------
Reporter: killyourtv | Owner: warner
Type: defect | Status: closed
Priority: critical | Milestone: 1.9.2
Component: code-network | Version: 1.9.1
Resolution: fixed | Keywords: introducer regression
Launchpad Bug: |
------------------------------+-----------------------------------
Changes (by Brian Warner <warner@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:5490/trunk]:
{{{
#!CommitTicketReference repository="trunk" revision="5490"
Fix introweb display for mixed V1/V2 clients. Closes #1721.
This significantly cleans up the IntroducerServer web-status renderers.
Instead of poking around in the introducer's internals, now the web-status
renderers get clean AnnouncementDescriptor and SubscriberDescriptor
objects. They are still somewhat foolscap-centric, but will provide a
clean
abstraction boundary for future improvements.
The specific #1721 bug was that old (V1) subscribers were handled by
wrapping their RemoteReference in a special WrapV1SubscriberInV2Interface
object, but the web-status display was trying to peek inside the object to
learn what host+port it was associated with, and the wrapper did not proxy
those extra attributes.
A test was added to test_introducer to make sure the introweb page renders
properly and at least contains the nicknames of both the V1 and V2
clients.
}}}
--
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1721#comment:6>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage
More information about the tahoe-lafs-trac-stream
mailing list