[tahoe-lafs-trac-stream] [tahoe-lafs] #1725: Tahoe reports catch-up incidents to a log gatherer with a Unicode filename, which results in them being dropped

[tahoe-lafs]

#1725: Tahoe reports catch-up incidents to a log gatherer with a Unicode filename,
which results in them being dropped
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  zooko
  davidsarah             |     Status:  new
         Type:  defect   |  Milestone:  1.9.2
     Priority:  major    |    Version:  1.9.1
    Component:  code-    |   Keywords:  regression logging incident
  nodeadmin              |  foolscap review-needed
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by zooko):

 One possible change would be to extend
 [https://github.com/warner/foolscap/blob/4a1be0f81c8014c5f5936ea41d0b364bcefd0164/foolscap/logging/interfaces.py#L19
 RILogObserver.new_incident]'s type-checking to allow unicode in addition
 to str. The old way of thinking is that things which are only ever going
 to be ASCII should be str, and things which might have non-ASCII chars
 should be unicode. The new way of thinking (exemplified by Python 3) is
 that things which contain non-human-meaningful binary data should be str
 (soon to be known as {{{bytestring}}}) and things which contain human-
 meaningful characters should be unicode. (Even if those human-meaningful
 characters will never be any but the characters found in ASCII.)

 So, if you feel like playing along with the Python way of doing things it
 makes sense to define the {{{name}}} variable (which looks like 'incident-
 TIMESTAMP-UNIQUE') as unicode.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1725#comment:2>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage