[tahoe-lafs-trac-stream] [tahoe-lafs] #1725: Tahoe reports catch-up incidents to a log gatherer with a Unicode filename, which results in them being dropped

[tahoe-lafs]

#1725: Tahoe reports catch-up incidents to a log gatherer with a Unicode filename,
which results in them being dropped
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  zooko
  davidsarah             |     Status:  new
         Type:  defect   |  Milestone:  1.9.2
     Priority:  major    |    Version:  1.9.1
    Component:  code-    |   Keywords:  regression logging incident
  nodeadmin              |  foolscap reviewed
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by davidsarah):

 Replying to [comment:2 zooko]:
 > One possible change would be to extend
 [https://github.com/warner/foolscap/blob/4a1be0f81c8014c5f5936ea41d0b364bcefd0164/foolscap/logging/interfaces.py#L19
 RILogObserver.new_incident]'s type-checking to allow unicode in addition
 to str. The old way of thinking is that things which are only ever going
 to be ASCII should be str, and things which might have non-ASCII chars
 should be unicode.

 Well, maybe, but it's a Tahoe bug that it failed to adhere to the implicit
 contract of {{{setLogDir}}} as taking a {{{str}}}. If we wanted to pass a
 Unicode path, we'd need to update foolscap to accept that (also for the
 "logport-furlfile" tub option), then change Tahoe to depend on that
 version of foolscap. And then foolscap would probably still end up
 converting it to a {{{str}}} to preserve wire protocol compatibility with
 log gatherers running an earlier version. Too much hassle IMHO.

 Thanks for the review.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1725#comment:5>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage