[tahoe-lafs-trac-stream] [tahoe-lafs] #1770: always include a useful message in calls to log.err

[tahoe-lafs]

#1770: always include a useful message in calls to log.err
----------------------------+--------------------
     Reporter:  davidsarah  |      Owner:
         Type:  defect      |     Status:  new
     Priority:  normal      |  Milestone:  1.11.0
    Component:  code        |    Version:  1.9.1
   Resolution:              |   Keywords:  error
Launchpad Bug:              |
----------------------------+--------------------
Changes (by davidsarah):

 * milestone:  1.10.0 => 1.11.0


Old description:

> From #1768:
> > The "Unhandled Error" (as opposed to the usual "Unhandled Error in
> Deferred") means that something called twisted's {{{log.err()}}} with a
> Failure or Exception, but nothing else (in particular not a why=
> argument). This is a pretty common (perhaps unfortunate) pattern in our
> code: tahoe has roughly 47 such calls, and Foolscap has about 29. So we
> don't really know what caught the exception (and therefore what ought to
> be handling it differently).
>
> We should fix all of these.

New description:

 From #1768:
 > The "Unhandled Error" (as opposed to the usual "Unhandled Error in
 Deferred") means that something called twisted's {{{log.err()}}} with a
 Failure or Exception, but nothing else (in particular not a why=
 argument). This is a pretty common (perhaps unfortunate) pattern in our
 code: tahoe has roughly 47 such calls, and Foolscap has about 29. So we
 don't really know what caught the exception (and therefore what ought to
 be handling it differently).

 We should fix all of these.

--

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1770#comment:3>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage