[tahoe-lafs-trac-stream] [tahoe-lafs] #1298: WUI cannot handle non-ASCII node nicknames

[tahoe-lafs]

#1298: WUI cannot handle non-ASCII node nicknames
---------------------------------+-----------------------------------------
     Reporter:  zooko            |      Owner:  zooko
         Type:  defect           |     Status:  new
     Priority:  major            |  Milestone:  1.10.0
    Component:  code-frontend-   |    Version:  1.8.1
  web                            |   Keywords:  unicode wui approval-needed
   Resolution:                   |
Launchpad Bug:                   |
---------------------------------+-----------------------------------------
Changes (by amiller):

 * keywords:  unicode wui review-needed => unicode wui approval-needed


Comment:

 Review:
  1. D-S fixed the bug by Replacing "n:render='string'" with
 "n:render='data'" in affected xhtml templates, which is a workaround to
 prevent Nevow from attempting an ascii decoding. D-S had to write a few
 new mockup structures in test_web.py to simulate the original bug. I ran
 the tests and looked to see if any other templates were missed.

  2. D-S removed a .decode('utf-8') from get_nickname, which is probably
 correct (since .decode('utf-8') is generally considered useless, doesn't
 exist in Python3, etc.), but what's the consequence? I put this line back
 in and all the tests still pass.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1298#comment:9>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage