[tahoe-lafs-trac-stream] [tahoe-lafs] #1812: parse_abbreviated_size doesn't accept T for terabytes (and other quibbles with the regex it uses)

[tahoe-lafs]

#1812: parse_abbreviated_size doesn't accept T for terabytes (and other quibbles
with the regex it uses)
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  zancas
  davidsarah             |     Status:  new
         Type:  defect   |  Milestone:  1.10.0
     Priority:  normal   |    Version:  1.9.2
    Component:  code     |   Keywords:  reserved_space storage error
   Resolution:           |  usability review-needed
Launchpad Bug:           |
-------------------------+-------------------------------------------------
Changes (by Zancas):

 * cc: zancas@… (added)


Comment:

 I've reviewed these changes and run the unittests they include.
 I concur that the doubled "BB" suffix now correctly raises a
 {{{ValueError}}}.

 I concur that Tera-, Peta-, and Exa-bytes are now correctly handled as
 scales of 2^40^, 2^50^, and 2^60^.
 I note that the "{{{^}}}" in the "pattern" argument to re.match is not
 strictly necessary, but assert that it is correct, and may enhance
 readability.

 I do not understand why the suffix's "I" and "i" are to be handled as they
 are, it seems to me that the pattern e.g. "iB", is an error, but it's
 plausible I'm simply unfamiliar with established convention.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1812#comment:7>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage