[tahoe-lafs-trac-stream] [tahoe-lafs] #1589: S3 backend: when a txaws operation gets an error response, include the full request URI and response body in the exception message, and maybe trigger an incident

[tahoe-lafs]

#1589: S3 backend: when a txaws operation gets an error response, include the full
request URI and response body in the exception message, and maybe trigger
an incident
------------------------------+------------------------------------
     Reporter:  davidsarah    |      Owner:  davidsarah
         Type:  defect        |     Status:  assigned
     Priority:  major         |  Milestone:  1.10.0
    Component:  code-storage  |    Version:  1.9.0b1
   Resolution:                |   Keywords:  error s3-backend txaws
Launchpad Bug:                |
------------------------------+------------------------------------
Changes (by davidsarah):

 * owner:   => davidsarah
 * status:  new => assigned


Comment:

 txaws is preserving the {{{xml_bytes}}}, {{{status}}}, and {{{response}}}
 in the args of the {{{S3Error}}} object (so we don't need a txaws patch),
 but they are not being included in the stringified form of the exception
 (line 58 of txaws/exception.py).

 So, we need an errback, probably after each operation in
 [source:ticket999-S3-backend/src/allmydata/storage/backends/s3/s3_bucket.py],
 that extracts this information, logs it, and raises another exception that
 includes it in the error message.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1589#comment:3>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage