[tahoe-lafs-trac-stream] [tahoe-lafs] #1589: S3 backend: when a txaws operation gets an error response, include the full request URI and response body in the exception message, and maybe trigger an incident

[tahoe-lafs]

#1589: S3 backend: when a txaws operation gets an error response, include the full
request URI and response body in the exception message, and maybe trigger
an incident
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  zancas
  davidsarah             |     Status:  new
         Type:  defect   |  Milestone:  1.10.0
     Priority:  major    |    Version:  1.9.0b1
    Component:  code-    |   Keywords:  error s3-backend txaws review-
  storage                |  needed
   Resolution:           |
Launchpad Bug:           |
-------------------------+-------------------------------------------------

Comment (by zooko):

 patch review:

 I guess it is redundant but not harmful to say that class {{{S3Bucket}}}
 {{{implements(IS3Bucket)}}}, since it now subclasses {{{S3BucketMixin}}}
 which {{{implements(IS3Bucket)}}}. I would tend to err on the side of
 removing that declaration from class {{{S3Bucket}}}, but I could go either
 way.

 Why do we need both the {{{f.trap(self.S3Error)}}} and the {{{except
 self.S3Error}}}? Don't those both mean the same thing -- one for twisted
 Failure instances and the other for Python Error instances? Don't we know
 which of those two types we might encounter there?

 Other than that, I saw no problems with it.

-- 
Ticket URL: <https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1589#comment:6>
tahoe-lafs <https://tahoe-lafs.org>
secure decentralized storage